thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Backport #71332 to 24.10: Fix inconsistent AST formatting when granting wrong wildcard grants (#71393)

Browse Source 
Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
This commit is contained in:
robot-ch-test-poll1 2024-11-06 22:30:03 +04:00 committed by GitHub
parent 254bdc9d0a
commit 22727423a0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/en/sql-reference/statements/grant.md
View File

@ -113,6 +113,7 @@ GRANT SELECT ON db*.* TO john -- correct
GRANT SELECT ON *.my_table TO john -- wrong GRANT SELECT ON *.my_table TO john -- wrong
GRANT SELECT ON foo*bar TO john -- wrong GRANT SELECT ON foo*bar TO john -- wrong
GRANT SELECT ON *suffix TO john -- wrong GRANT SELECT ON *suffix TO john -- wrong
GRANT SELECT(foo) ON db.table* TO john -- wrong
``` ```
## Privileges ## Privileges

3
src/Parsers/Access/ParserGrantQuery.cpp
View File

@ -155,6 +155,9 @@ namespace
for (auto & [access_flags, columns] : access_and_columns) for (auto & [access_flags, columns] : access_and_columns)
{ {
if (wildcard && !columns.empty())
return false;
AccessRightsElement element; AccessRightsElement element;
element.access_flags = access_flags; element.access_flags = access_flags;
element.columns = std::move(columns); element.columns = std::move(columns);

2
tests/queries/0_stateless/03141_wildcard_grants.sql
View File

@ -19,4 +19,6 @@ REVOKE SELECT ON team*.* FROM user_03141;
SHOW GRANTS FOR user_03141; SHOW GRANTS FOR user_03141;
SELECT '---'; SELECT '---';
GRANT SELECT(bar) ON foo.test* TO user_03141; -- { clientError SYNTAX_ERROR }
DROP USER user_03141; DROP USER user_03141;