thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 01:25:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a comment about broken logic for skipping checks

Browse Source
This commit is contained in:
Mikhail f. Shiryaev 2022-01-26 15:30:59 +01:00
parent 462e95d0fa
commit 22eddff0d5
No known key found for this signature in database
GPG Key ID: 4B02ED204C7D93F4
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/ci/pr_info.py
View File

@ -235,6 +235,7 @@ class PRInfo:
return False
def can_skip_builds_and_use_version_from_master(self):
# TODO: See a broken loop
if "force tests" in self.labels:
return False
@ -242,6 +243,7 @@ class PRInfo:
return False
for f in self.changed_files:
# TODO: this logic is broken, should be fixed before using
if (
not f.startswith("tests/queries")
or not f.startswith("tests/integration")
@ -252,6 +254,7 @@ class PRInfo:
return True
def can_skip_integration_tests(self):
# TODO: See a broken loop
if "force tests" in self.labels:
return False
@ -259,6 +262,7 @@ class PRInfo:
return False
for f in self.changed_files:
# TODO: this logic is broken, should be fixed before using
if not f.startswith("tests/queries") or not f.startswith(
"tests/performance"
):
@ -267,6 +271,7 @@ class PRInfo:
return True
def can_skip_functional_tests(self):
# TODO: See a broken loop
if "force tests" in self.labels:
return False
@ -274,6 +279,7 @@ class PRInfo:
return False
for f in self.changed_files:
# TODO: this logic is broken, should be fixed before using
if not f.startswith("tests/integration") or not f.startswith(
"tests/performance"
):