thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-19 14:11:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return data type revise

Browse Source
This commit is contained in:
keenwolf 2021-01-17 14:27:18 +08:00
parent 8f3cdb69e6
commit 2379902e2a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/Functions/FunctionFile.cpp
View File

@ -41,8 +41,8 @@ namespace DB
DataTypePtr getReturnTypeImpl(const ColumnsWithTypeAndName & arguments) const override
{
if (!isStringOrFixedString(arguments[0].type))
throw Exception(getName() + " is only implemented for types String and FixedString", ErrorCodes::NOT_IMPLEMENTED);
if (!isString(arguments[0].type))
throw Exception(getName() + " is only implemented for types String", ErrorCodes::NOT_IMPLEMENTED);
return std::make_shared<DataTypeString>();
}
@ -78,7 +78,7 @@ namespace DB
in.readStrict(res_buf, file_len);
/*
//Method-2: Read directly into the String buf, which avoiding one copy from PageCache to ReadBuffer
//Method-2(Just for reference): Read directly into the String buf, which avoiding one copy from PageCache to ReadBuffer
int fd;
if (-1 == (fd = open(file_absolute_path.c_str(), O_RDONLY)))
throwFromErrnoWithPath("Cannot open file " + std::string(file_absolute_path), std::string(file_absolute_path),