thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-28 02:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert unnecessary improving in ContextAccessCache for now.

Browse Source
This commit is contained in:
Vitaly Baranov 2023-07-17 14:52:17 +02:00
parent 815a3857de
commit 2379d8c9d5
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Access/AccessControl.cpp
View File

@ -71,7 +71,6 @@ public:
explicit ContextAccessCache(const AccessControl & access_control_) : access_control(access_control_) {}
std::shared_ptr<const ContextAccess> getContextAccess(const ContextAccessParams & params)
{
{
std::lock_guard lock{mutex};
auto x = cache.get(params);
@ -82,16 +81,11 @@ public:
else
return *x;
}
}
/// TODO: There is no need to keep the `ContextAccessCache::mutex` locked while we're calculating access rights.
auto res = std::make_shared<ContextAccess>(access_control, params);
res->initialize();
{
std::lock_guard lock{mutex};
cache.add(params, res);
}
return res;
}