Merge branch 'fuzz_functions' of https://github.com/xolm/ClickHouse into xolm-fuzz_functions

This commit is contained in:
Alexey Milovidov 2020-05-11 02:42:55 +03:00
commit 2438a510b0
3 changed files with 112 additions and 1 deletions

View File

@ -0,0 +1,98 @@
#include <Columns/ColumnString.h>
#include <DataTypes/DataTypeString.h>
#include <Functions/FunctionFactory.h>
#include <Functions/FunctionHelpers.h>
#include <Functions/IFunctionImpl.h>
#include <Common/thread_local_rng.h>
namespace DB
{
namespace ErrorCodes
{
extern const int NUMBER_OF_ARGUMENTS_DOESNT_MATCH;
extern const int ILLEGAL_TYPE_OF_ARGUMENT;
extern const int TOO_LARGE_STRING_SIZE;
}
/* Generate random string of specified length with fully random bytes (including zero). */
class FunctionRandomString : public IFunction
{
public:
static constexpr auto name = "randomString";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionRandomString>(); }
String getName() const override { return name; }
bool isVariadic() const override { return true; }
size_t getNumberOfArguments() const override { return 0; }
DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
{
if (arguments.empty())
throw Exception(
"Function " + getName() + " requires at least one argument: the size of resulting string",
ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH);
if (arguments.size() > 2)
throw Exception(
"Function " + getName() + " requires at most two arguments: the size of resulting string and optional disambiguation tag",
ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH);
const IDataType & length_type = *arguments[0];
if (!isNumber(length_type))
throw Exception("First argument of function " + getName() + " must have numeric type", ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT);
return std::make_shared<DataTypeString>();
}
bool isDeterministic() const override { return false; }
bool isDeterministicInScopeOfQuery() const override { return false; }
void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override
{
auto col_to = ColumnString::create();
ColumnString::Chars & data_to = col_to->getChars();
ColumnString::Offsets & offsets_to = col_to->getOffsets();
offsets_to.resize(input_rows_count);
const IColumn & length_column = *block.getByPosition(arguments[0]).column;
IColumn::Offset offset = 0;
for (size_t row_num = 0; row_num < input_rows_count; ++row_num)
{
size_t length = length_column.getUInt(row_num);
if (length > (1 << 30))
throw Exception("Too large string size in function " + getName(), ErrorCodes::TOO_LARGE_STRING_SIZE);
IColumn::Offset next_offset = offset + length + 1;
data_to.resize(next_offset);
offsets_to[row_num] = next_offset;
auto * data_to_ptr = data_to.data(); // avoid assert on array indexing after end
for (size_t pos = offset, end = offset + length; pos < end;
pos += sizeof(UInt64)) // We have padding in column buffers that we can overwrite.
{
UInt64 rand = thread_local_rng();
*reinterpret_cast<UInt64 *>(data_to_ptr + pos) = rand;
}
data_to[offset + length] = 0;
offset = next_offset;
}
block.getByPosition(result).column = std::move(col_to);
}
};
void registerFunctionRandomString(FunctionFactory & factory)
{
factory.registerFunction<FunctionRandomString>();
}
}

View File

@ -1,6 +1,5 @@
namespace DB namespace DB
{ {
class FunctionFactory; class FunctionFactory;
void registerFunctionRand(FunctionFactory & factory); void registerFunctionRand(FunctionFactory & factory);
@ -8,6 +7,7 @@ void registerFunctionRand64(FunctionFactory & factory);
void registerFunctionRandConstant(FunctionFactory & factory); void registerFunctionRandConstant(FunctionFactory & factory);
void registerFunctionGenerateUUIDv4(FunctionFactory & factory); void registerFunctionGenerateUUIDv4(FunctionFactory & factory);
void registerFunctionRandomPrintableASCII(FunctionFactory & factory); void registerFunctionRandomPrintableASCII(FunctionFactory & factory);
void registerFunctionRandomString(FunctionFactory & factory);
void registerFunctionsRandom(FunctionFactory & factory) void registerFunctionsRandom(FunctionFactory & factory)
{ {
@ -16,6 +16,7 @@ void registerFunctionsRandom(FunctionFactory & factory)
registerFunctionRandConstant(factory); registerFunctionRandConstant(factory);
registerFunctionGenerateUUIDv4(factory); registerFunctionGenerateUUIDv4(factory);
registerFunctionRandomPrintableASCII(factory); registerFunctionRandomPrintableASCII(factory);
registerFunctionRandomString(factory);
} }
} }

View File

@ -0,0 +1,12 @@
<test>
<query>SELECT count() FROM zeros(1000000) WHERE NOT ignore(randomString(10))</query>
<query>SELECT count() FROM zeros(1000000) WHERE NOT ignore(randomString(100))</query>
<query>SELECT count() FROM zeros(100000) WHERE NOT ignore(randomString(1000))</query>
<query>SELECT count() FROM zeros(10000) WHERE NOT ignore(randomString(10000))</query>
<query>SELECT count() FROM zeros(10000000) WHERE NOT ignore(randomString(rand() % 10))</query>
<query>SELECT count() FROM zeros(10000000) WHERE NOT ignore(randomString(rand() % 100))</query>
<query>SELECT count() FROM zeros(1000000) WHERE NOT ignore(randomString(rand() % 1000))</query>
</test>