thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix UBSan report in GatherUtils

Browse Source
This commit is contained in:
Alexey Milovidov 2021-01-31 10:10:37 +03:00
parent d93dad0ec3
commit 248540e58f
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Functions/GatherUtils/Algorithms.h
View File

@ -711,7 +711,7 @@ void resizeDynamicSize(ArraySource && array_source, ValueSource && value_source,
}
else
{
auto length = static_cast<size_t>(-size);
auto length = -static_cast<size_t>(size);
if (length > MAX_ARRAY_SIZE)
throw Exception(ErrorCodes::TOO_LARGE_ARRAY_SIZE, "Too large array size: {}, maximum: {}",
length, MAX_ARRAY_SIZE);
@ -760,7 +760,7 @@ void resizeConstantSize(ArraySource && array_source, ValueSource && value_source
}
else
{
auto length = static_cast<size_t>(-size);
auto length = -static_cast<size_t>(size);
if (length > MAX_ARRAY_SIZE)
throw Exception(ErrorCodes::TOO_LARGE_ARRAY_SIZE, "Too large array size: {}, maximum: {}",
length, MAX_ARRAY_SIZE);

0
tests/queries/0_stateless/01682_gather_utils_ubsan.reference Normal file
View File

1
tests/queries/0_stateless/01682_gather_utils_ubsan.sql Normal file
View File

@ -0,0 +1 @@
SELECT arrayResize([1, 2, 3], -9223372036854775808); -- { serverError 128 }