thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 09:02:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #29666 from kitaisreal/user-defined-executable-functions-added-implicit-cast

Browse Source 
UserDefinedExecutableFunctions added implicit cast
This commit is contained in:
Maksim Kita 2021-10-04 10:34:31 +03:00 committed by GitHub
commit 25d1588d0a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/Interpreters/UserDefinedExecutableFunctionFactory.cpp
View File

@ -10,6 +10,7 @@
#include <AggregateFunctions/AggregateFunctionFactory.h>
#include <Interpreters/ExternalUserDefinedExecutableFunctionsLoader.h>
#include <Interpreters/Context.h>
#include <Interpreters/castColumn.h>
namespace DB
@ -43,36 +44,41 @@ public:
bool useDefaultImplementationForNulls() const override { return true; }
bool isDeterministic() const override { return false; }
DataTypePtr getReturnTypeImpl(const DataTypes & arguments) const override
DataTypePtr getReturnTypeImpl(const DataTypes &) const override
{
const auto & configuration = executable_function->getConfiguration();
for (size_t i = 0; i < arguments.size(); ++i)
{
const auto & expected_argument_type = configuration.argument_types[i];
if (!areTypesEqual(expected_argument_type, arguments[i]))
throw Exception(ErrorCodes::UNSUPPORTED_METHOD,
"Function {} for {} argument expected {} actual {}",
getName(),
i,
expected_argument_type->getName(),
arguments[i]->getName());
}
return configuration.result_type;
}
ColumnPtr executeImpl(const ColumnsWithTypeAndName & arguments, const DataTypePtr & result_type, size_t input_rows_count) const override
{
const auto & configuration = executable_function->getConfiguration();
auto arguments_copy = arguments;
for (size_t i = 0; i < arguments.size(); ++i)
{
auto & column_with_type = arguments_copy[i];
column_with_type.column = column_with_type.column->convertToFullColumnIfConst();
const auto & argument_type = configuration.argument_types[i];
if (areTypesEqual(arguments_copy[i].type, argument_type))
continue;
ColumnWithTypeAndName column_to_cast = {column_with_type.column, column_with_type.type, column_with_type.name};
column_with_type.column = castColumnAccurate(column_to_cast, argument_type);
column_with_type.type = argument_type;
column_with_type = column_to_cast;
}
std::unique_ptr<ShellCommand> process = getProcess();
ColumnWithTypeAndName result(result_type, "result");
Block result_block({result});
Block arguments_block(arguments);
Block arguments_block(arguments_copy);
auto * process_in = &process->in;
const auto & configuration = executable_function->getConfiguration();
auto process_pool = executable_function->getProcessPool();
bool is_executable_pool_function = (process_pool != nullptr);

1
tests/queries/0_stateless/02043_user_defined_executable_function_implicit_cast.reference Normal file
View File

@ -0,0 +1 @@
4

1
tests/queries/0_stateless/02043_user_defined_executable_function_implicit_cast.sql Normal file
View File

@ -0,0 +1 @@
SELECT test_function(2, 2);