thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-21 09:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestion for code review, changes in StorageSystemTables getFilteredTables

Browse Source 
Co-authored-by: Azat Khuzhin <a3at.mail@gmail.com>
This commit is contained in:
vdimir 2021-12-30 13:54:39 +03:00
parent 0c714e8c7e
commit 2686a189de
No known key found for this signature in database
GPG Key ID: 9B404D301C0CC7EB
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Storages/System/StorageSystemTables.cpp
View File

@ -88,18 +88,18 @@ static ColumnPtr getFilteredDatabases(const SelectQueryInfo & query_info, Contex
return block.getByPosition(0).column;
}
static ColumnPtr getFilteredTables(const ASTPtr & query, ColumnPtr & filtered_databases_column, ContextPtr context)
static ColumnPtr getFilteredTables(const ASTPtr & query, const ColumnPtr & filtered_databases_column, ContextPtr context)
{
MutableColumnPtr column = ColumnString::create();
size_t database_idx = 0;
for (; database_idx < filtered_databases_column->size(); ++database_idx)
for (size_t database_idx = 0; database_idx < filtered_databases_column->size(); ++database_idx)
{
auto database_name = filtered_databases_column->getDataAt(database_idx).toString();
DatabasePtr database = DatabaseCatalog::instance().getDatabase(database_name);
DatabaseTablesIteratorPtr table_it = database->getTablesIterator(context);
const auto & database_name = filtered_databases_column->getDataAt(database_idx).toString();
DatabasePtr database = DatabaseCatalog::instance().tryGetDatabase(database_name);
if (!database)
continue;
for (; table_it->isValid(); table_it->next())
for (auto table_it = database->getTablesIterator(context); table_it->isValid(); table_it->next())
column->insert(table_it->name());
}