finalize in destructor

src/Common/RingBuffer.h

@@ -21,15 +21,9 @@ public:
         buffer.assign(capacity, {});
     }
 
-    size_t size() const
-    {
-        return count;
-    }
+    size_t size() const { return count; }
 
-    bool empty() const
-    {
-        return count == 0;
-    }
+    bool empty() const { return count == 0; }
 
     bool tryPush(T element)
     {

src/Storages/MergeTree/BackgroundJobsExecutor.cpp

@@ -111,8 +111,6 @@ void BackgroundJobAssignee::finish()
         getContext()->getFetchesExecutor()->removeTasksCorrespondingToStorage(storage_id);
         getContext()->getMergeMutateExecutor()->removeTasksCorrespondingToStorage(storage_id);
     }
-
-    finished = true;
 }
 
 
@@ -141,7 +139,14 @@ catch (...) /// Catch any exception to avoid thread termination.
 
 BackgroundJobAssignee::~BackgroundJobAssignee()
 {
-    assert(finished);
+    try
+    {
+        finish();
+    }
+    catch (...)
+    {
+        tryLogCurrentException(__PRETTY_FUNCTION__);
+    }
 }
 
 }

src/Storages/MergeTree/BackgroundJobsExecutor.h

@@ -48,8 +48,6 @@ private:
     /// Mutex for thread safety
     std::mutex holder_mutex;
 
-    bool finished{false};
-
 public:
     enum class Type
     {