thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 17:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #21532 from kitaisreal/pod-array-left-pad-not-multiple-of-element-crash-fix

Browse Source 
Pod array left pad not multiple of element crash fix
This commit is contained in:
Maksim Kita 2021-03-09 14:14:52 +03:00 committed by GitHub
commit 289712f19d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Common/PODArray.h
View File

@ -335,7 +335,7 @@ public:
using const_iterator = const T *;
PODArray() {}
PODArray() = default;
PODArray(size_t n)
{

26
src/Common/tests/gtest_pod_array.cpp
View File

@ -66,3 +66,29 @@ TEST(Common, PODNoOverallocation)
EXPECT_EQ(capacities, (std::vector<size_t>{4065, 8161, 16353, 32737, 65505, 131041, 262113, 524257, 1048545}));
}
template <size_t size>
struct ItemWithSize
{
char v[size] {};
};
TEST(Common, PODInsertElementSizeNotMultipleOfLeftPadding)
{
using ItemWith24Size = ItemWithSize<24>;
PaddedPODArray<ItemWith24Size> arr1_initially_empty;
size_t items_to_insert_size = 120000;
for (size_t test = 0; test < items_to_insert_size; ++test)
arr1_initially_empty.emplace_back();
EXPECT_EQ(arr1_initially_empty.size(), items_to_insert_size);
PaddedPODArray<ItemWith24Size> arr2_initially_nonempty;
for (size_t test = 0; test < items_to_insert_size; ++test)
arr2_initially_nonempty.emplace_back();
EXPECT_EQ(arr1_initially_empty.size(), items_to_insert_size);
}