thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-14 19:45:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #49203 from kssenii/fix-system-error-from-cache

Browse Source 
Catch exceptions from create_directories in fs cache
This commit is contained in:
Kseniia Sumarokova 2023-04-27 12:29:38 +02:00 committed by GitHub
commit 28dee371e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 38 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

70
src/Interpreters/Cache/FileCache.cpp
View File

@ -497,7 +497,7 @@ FileCache::FileSegmentCell * FileCache::addCell(
/// Create a file segment cell and put it in `files` map by [key][offset].
if (!size)
return nullptr; /// Empty files are not cached.
throw Exception(ErrorCodes::LOGICAL_ERROR, "Zero size files are not allowed");
if (files[key].contains(offset))
throw Exception(
@ -505,54 +505,60 @@ FileCache::FileSegmentCell * FileCache::addCell(
"Cache cell already exists for key: `{}`, offset: {}, size: {}.\nCurrent cache structure: {}",
key.toString(), offset, size, dumpStructureUnlocked(key, cache_lock));
auto skip_or_download = [&]() -> FileSegmentPtr
FileSegment::State result_state = state;
if (state == FileSegment::State::EMPTY && enable_cache_hits_threshold)
{
FileSegment::State result_state = state;
if (state == FileSegment::State::EMPTY && enable_cache_hits_threshold)
auto record = stash_records.find({key, offset});
if (record == stash_records.end())
{
auto record = stash_records.find({key, offset});
auto priority_iter = stash_priority->add(key, offset, 0, cache_lock);
stash_records.insert({{key, offset}, priority_iter});
if (record == stash_records.end())
if (stash_priority->getElementsNum(cache_lock) > max_stash_element_size)
{
auto priority_iter = stash_priority->add(key, offset, 0, cache_lock);
stash_records.insert({{key, offset}, priority_iter});
if (stash_priority->getElementsNum(cache_lock) > max_stash_element_size)
{
auto remove_priority_iter = stash_priority->getLowestPriorityWriteIterator(cache_lock);
stash_records.erase({remove_priority_iter->key(), remove_priority_iter->offset()});
remove_priority_iter->removeAndGetNext(cache_lock);
}
/// For segments that do not reach the download threshold,
/// we do not download them, but directly read them
result_state = FileSegment::State::SKIP_CACHE;
auto remove_priority_iter = stash_priority->getLowestPriorityWriteIterator(cache_lock);
stash_records.erase({remove_priority_iter->key(), remove_priority_iter->offset()});
remove_priority_iter->removeAndGetNext(cache_lock);
}
else
{
auto priority_iter = record->second;
priority_iter->use(cache_lock);
result_state = priority_iter->hits() >= enable_cache_hits_threshold
? FileSegment::State::EMPTY
: FileSegment::State::SKIP_CACHE;
}
/// For segments that do not reach the download threshold,
/// we do not download them, but directly read them
result_state = FileSegment::State::SKIP_CACHE;
}
else
{
auto priority_iter = record->second;
priority_iter->use(cache_lock);
return std::make_shared<FileSegment>(offset, size, key, this, result_state, settings);
};
result_state = priority_iter->hits() >= enable_cache_hits_threshold
? FileSegment::State::EMPTY
: FileSegment::State::SKIP_CACHE;
}
}
FileSegmentCell cell(skip_or_download(), this, cache_lock);
auto & offsets = files[key];
if (offsets.empty())
{
auto key_path = getPathInLocalCache(key);
if (!fs::exists(key_path))
fs::create_directories(key_path);
{
try
{
fs::create_directories(key_path);
}
catch (...)
{
tryLogCurrentException(__PRETTY_FUNCTION__);
result_state = FileSegment::State::SKIP_CACHE;
}
}
}
auto file_segment = std::make_shared<FileSegment>(offset, size, key, this, result_state, settings);
FileSegmentCell cell(std::move(file_segment), this, cache_lock);
auto [it, inserted] = offsets.insert({offset, std::move(cell)});
if (!inserted)
throw Exception(