thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix query hang with connections_with_failover_max_tries = 0 (endless loop)

Browse Source
This commit is contained in:
Azat Khuzhin 2020-10-12 22:01:15 +03:00
parent a21b42f1f8
commit 2947eff878
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Common/PoolWithFailoverBase.h
View File

@ -229,7 +229,7 @@ PoolWithFailoverBase<TNestedPool>::getMany(
ShuffledPool & shuffled_pool = shuffled_pools[i];
TryResult & result = try_results[i];
if (shuffled_pool.error_count >= max_tries || !result.entry.isNull())
if (max_tries && (shuffled_pool.error_count >= max_tries || !result.entry.isNull()))
continue;
std::string fail_message;

1
tests/queries/0_stateless/01521_connections_with_failover_max_tries_0.reference Normal file
View File

@ -0,0 +1 @@
0

3
tests/queries/0_stateless/01521_connections_with_failover_max_tries_0.sql Normal file
View File

@ -0,0 +1,3 @@
-- regression for endless loop with connections_with_failover_max_tries=0
set connections_with_failover_max_tries=0;
select * from remote('127.2', system.one);