Freebsd build fixes (#5083)

cmake/find_execinfo.cmake

@@ -1,9 +1,8 @@
 if (OS_FREEBSD)
     find_library (EXECINFO_LIBRARY execinfo)
     find_library (ELF_LIBRARY elf)
-    message (STATUS "Using execinfo: ${EXECINFO_LIBRARY}")
+    set (EXECINFO_LIBRARIES ${EXECINFO_LIBRARY} ${ELF_LIBRARY})
-    message (STATUS "Using elf: ${ELF_LIBRARY}")
+    message (STATUS "Using execinfo: ${EXECINFO_LIBRARIES}")
 else ()
-    set (EXECINFO_LIBRARY "")
+    set (EXECINFO_LIBRARIES "")
-    set (ELF_LIBRARY "")
 endif ()

dbms/CMakeLists.txt

@@ -194,8 +194,7 @@ target_link_libraries (clickhouse_common_io
     ${CITYHASH_LIBRARIES}
         PRIVATE
     ${ZLIB_LIBRARIES}
-    ${EXECINFO_LIBRARY}
+    ${EXECINFO_LIBRARIES}
-    ${ELF_LIBRARY}
         PUBLIC
     ${Boost_SYSTEM_LIBRARY}
         PRIVATE

dbms/programs/clang/Compiler-5.0.0/CMakeLists.txt

@@ -46,7 +46,7 @@ LLVMSupport
 #PollyISL
 #PollyPPCG
 
-PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARY} Threads::Threads
+PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARIES} Threads::Threads
 ${MALLOC_LIBRARIES}
 ${GLIBC_COMPATIBILITY_LIBRARIES}
 ${MEMCPY_LIBRARIES}

dbms/programs/clang/Compiler-6.0.0/CMakeLists.txt

@@ -46,7 +46,7 @@ ${REQUIRED_LLVM_LIBRARIES}
 #PollyISL
 #PollyPPCG
 
-PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARY} Threads::Threads
+PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARIES} Threads::Threads
 ${MALLOC_LIBRARIES}
 ${GLIBC_COMPATIBILITY_LIBRARIES}
 ${MEMCPY_LIBRARIES}

dbms/programs/clang/Compiler-7.0.0/CMakeLists.txt

@@ -42,7 +42,7 @@ lldCore
 
 ${REQUIRED_LLVM_LIBRARIES}
 
-PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARY} Threads::Threads
+PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARIES} Threads::Threads
 ${MALLOC_LIBRARIES}
 ${GLIBC_COMPATIBILITY_LIBRARIES}
 ${MEMCPY_LIBRARIES}

dbms/programs/clang/Compiler-7.0.0bundled/CMakeLists.txt

@@ -42,7 +42,7 @@ lldCore
 
 ${REQUIRED_LLVM_LIBRARIES}
 
-PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARY} Threads::Threads
+PUBLIC ${ZLIB_LIBRARIES} ${EXECINFO_LIBRARIES} Threads::Threads
 ${MALLOC_LIBRARIES}
 ${GLIBC_COMPATIBILITY_LIBRARIES}
 ${MEMCPY_LIBRARIES}

dbms/tests/clickhouse-test

@@ -116,6 +116,7 @@ exit_code = 0
 #def run_tests_array(all_tests, suite, suite_dir, suite_tmp_dir, run_total):
 def run_tests_array(all_tests_with_params):
     all_tests, suite, suite_dir, suite_tmp_dir, run_total = all_tests_with_params
+    global exit_code
     global SERVER_DIED
 
     OP_SQUARE_BRACKET = colored("[", args, attrs=['bold'])
@@ -393,7 +394,7 @@ def main(args):
         suite = suite_re_obj.group(1)
         if os.path.isdir(suite_dir):
 
-            if 'stateful' in suite and not is_data_present():
+            if 'stateful' in suite and not args.no_stateful and not is_data_present():
                 print("Won't run stateful tests because test data wasn't loaded.")
                 continue
             if 'stateless' in suite and args.no_stateless:

libs/libcommon/CMakeLists.txt

@@ -91,9 +91,13 @@ target_include_directories (common BEFORE PRIVATE ${CCTZ_INCLUDE_DIR})
 target_include_directories (common PUBLIC ${COMMON_INCLUDE_DIR})
 
 if (NOT USE_INTERNAL_BOOST_LIBRARY)
-    target_include_directories (common BEFORE PUBLIC ${Boost_INCLUDE_DIRS})
+    target_include_directories (common SYSTEM BEFORE PUBLIC ${Boost_INCLUDE_DIRS})
 endif ()
 
+if(NOT USE_INTERNAL_POCO_LIBRARY)
+    target_include_directories (common SYSTEM BEFORE PUBLIC ${Poco_Foundation_INCLUDE_DIR})
+endif()
+
 target_link_libraries (common
         PUBLIC
     ${Poco_Foundation_LIBRARY}

libs/libdaemon/CMakeLists.txt

@@ -22,4 +22,4 @@ endif ()
 
 target_include_directories (daemon PUBLIC include)
 
-target_link_libraries (daemon PRIVATE clickhouse_common_io clickhouse_common_config common ${Poco_Net_LIBRARY} ${Poco_Util_LIBRARY} ${EXECINFO_LIBRARY} ${ELF_LIBRARY})
+target_link_libraries (daemon PRIVATE clickhouse_common_io clickhouse_common_config common ${Poco_Net_LIBRARY} ${Poco_Util_LIBRARY} ${EXECINFO_LIBRARIES})

libs/libmysqlxx/cmake/find_mysqlclient.cmake

@@ -1,17 +1,17 @@
-option (ENABLE_MYSQL "Enable MySQL" ${OS_LINUX})
+option(ENABLE_MYSQL "Enable MySQL" 1)
-if (OS_LINUX)
+if(ENABLE_MYSQL)
-    option (USE_INTERNAL_MYSQL_LIBRARY "Set to FALSE to use system mysqlclient library instead of bundled" ${NOT_UNBUNDLED})
+    if(OS_LINUX)
-else ()
+        option(USE_INTERNAL_MYSQL_LIBRARY "Set to FALSE to use system mysqlclient library instead of bundled" ${NOT_UNBUNDLED})
-    option (USE_INTERNAL_MYSQL_LIBRARY "Set to FALSE to use system mysqlclient library instead of bundled" OFF)
+    else()
-endif ()
+        option(USE_INTERNAL_MYSQL_LIBRARY "Set to FALSE to use system mysqlclient library instead of bundled" OFF)
+    endif()
 
-if (USE_INTERNAL_MYSQL_LIBRARY AND NOT EXISTS "${ClickHouse_SOURCE_DIR}/contrib/mariadb-connector-c/README.md")
+    if(USE_INTERNAL_MYSQL_LIBRARY AND NOT EXISTS "${ClickHouse_SOURCE_DIR}/contrib/mariadb-connector-c/README.md")
-    message (WARNING "submodule contrib/mariadb-connector-c is missing. to fix try run: \n git submodule update --init --recursive")
+        message(WARNING "submodule contrib/mariadb-connector-c is missing. to fix try run: \n git submodule update --init --recursive")
-   set (USE_INTERNAL_MYSQL_LIBRARY 0)
+        set(USE_INTERNAL_MYSQL_LIBRARY 0)
-endif ()
+    endif()
 
 
-if (ENABLE_MYSQL)
     if (USE_INTERNAL_MYSQL_LIBRARY)
         set (MYSQLCLIENT_LIBRARIES mysqlclient)
         set (USE_MYSQL 1)