Small enhancements. [#CLICKHOUSE-3452]

This commit is contained in:
Vitaliy Lyudvichenko 2017-11-29 14:54:37 +03:00
parent 9229961721
commit 2afbd8bcee
2 changed files with 16 additions and 5 deletions

View File

@ -187,7 +187,7 @@ bool MergeTreeDataMerger::selectPartsToMerge(
if (prev_part && part->info.partition_id == (*prev_part)->info.partition_id if (prev_part && part->info.partition_id == (*prev_part)->info.partition_id
&& part->info.min_block < (*prev_part)->info.max_block) && part->info.min_block < (*prev_part)->info.max_block)
{ {
LOG_ERROR(log, "Part " << part->getNameWithState() << " intersects previous part " << (*prev_part)->getNameWithState()); LOG_ERROR(log, "Part " << part->name << " intersects previous part " << (*prev_part)->name);
} }
prev_part = &part; prev_part = &part;

View File

@ -53,11 +53,22 @@ BlockInputStreams StorageSystemParts::read(
const size_t max_block_size, const size_t max_block_size,
const unsigned num_streams) const unsigned num_streams)
{ {
//check(column_names); bool has_state_column = false;
processed_stage = QueryProcessingStage::FetchColumns; Names real_column_names;
auto it_state_column = std::find(column_names.begin(), column_names.end(), "_state"); for (const String & column_name : column_names)
bool has_state_column = it_state_column != column_names.end(); {
if (column_name == "_state")
has_state_column = true;
else
real_column_names.emplace_back(column_name);
}
/// Do not check if only _state column is requested
if (!(has_state_column && real_column_names.empty()))
check(real_column_names);
processed_stage = QueryProcessingStage::FetchColumns;
/// Will apply WHERE to subset of columns and then add more columns. /// Will apply WHERE to subset of columns and then add more columns.
/// This is kind of complicated, but we use WHERE to do less work. /// This is kind of complicated, but we use WHERE to do less work.