Incorporate review feedback

This commit is contained in:
Robert Schulze 2023-07-27 08:55:19 +00:00
parent ed5393ef03
commit 2b18872e86
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
3 changed files with 10 additions and 10 deletions

View File

@ -112,10 +112,10 @@ Columns:
- `used_storages` ([Array(String)](../../sql-reference/data-types/array.md)) — Canonical names of `storages`, which were used during query execution.
- `used_table_functions` ([Array(String)](../../sql-reference/data-types/array.md)) — Canonical names of `table functions`, which were used during query execution.
- `query_cache_usage` ([Enum8](../../sql-reference/data-types/enum.md)) — Usage of the [query cache](../query-cache.md) during query execution. Values:
- `'None' = 1` = The query result was neither written into nor read from the query cache.
- `'Write' = 1` = The query result was written into the query cache.
- `'Read' = 1` = The query result was read from the query cache.
- `'Unknown' = 1` = Unknown status.
- `'Unknown' = 1` = Status unknown.
- `'None' = 2` = The query result was neither written into nor read from the query cache.
- `'Write' = 3` = The query result was written into the query cache.
- `'Read' = 4` = The query result was read from the query cache.
**Example**

View File

@ -27,10 +27,10 @@ public:
enum class Usage
{
/// starts at 1 for compatibitity with DataTypeEnum8
None = 1, /// query result neither written nor read into/from query cache
Write, /// query result wrote into query cache
Read, /// query result read from query cache
Unknown, /// we don't know what what happened
Unknown = 1, /// we don't know what what happened
None, /// query result neither written nor read into/from query cache
Write, /// query result written into query cache
Read, /// query result read from query cache
};
/// Represents a query result in the cache.

View File

@ -44,10 +44,10 @@ NamesAndTypesList QueryLogElement::getNamesAndTypes()
auto query_cache_usage_datatype = std::make_shared<DataTypeEnum8>(
DataTypeEnum8::Values
{
{"Unknown", static_cast<Int8>(QueryCache::Usage::Unknown)},
{"None", static_cast<Int8>(QueryCache::Usage::None)},
{"Write", static_cast<Int8>(QueryCache::Usage::Write)},
{"Read", static_cast<Int8>(QueryCache::Usage::Read)},
{"Unknown", static_cast<Int8>(QueryCache::Usage::Unknown)}
{"Read", static_cast<Int8>(QueryCache::Usage::Read)}
});
auto low_cardinality_string = std::make_shared<DataTypeLowCardinality>(std::make_shared<DataTypeString>());