thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 17:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add function isValidIdentifier().

Browse Source
This commit is contained in:
Vitaly Baranov 2020-08-08 19:34:35 +03:00
parent 5401694138
commit 2c5a2b2f43
2 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/Common/StringUtils/StringUtils.h
View File

@ -122,6 +122,11 @@ inline bool isPrintableASCII(char c)
return uc >= 32 && uc <= 126; /// 127 is ASCII DEL. return uc >= 32 && uc <= 126; /// 127 is ASCII DEL.
} }
inline bool isValidIdentifier(const std::string_view & str)
{
return !str.empty() && isValidIdentifierBegin(str[0]) && std::all_of(str.begin() + 1, str.end(), isWordCharASCII);
}
/// Works assuming isAlphaASCII. /// Works assuming isAlphaASCII.
inline char toLowerIfAlphaASCII(char c) inline char toLowerIfAlphaASCII(char c)
{ {

18
src/IO/WriteHelpers.cpp
View File

@ -68,22 +68,10 @@ void writeException(const Exception & e, WriteBuffer & buf, bool with_stack_trac
template <typename F> template <typename F>
static inline void writeProbablyQuotedStringImpl(const StringRef & s, WriteBuffer & buf, F && write_quoted_string) static inline void writeProbablyQuotedStringImpl(const StringRef & s, WriteBuffer & buf, F && write_quoted_string)
{ {
if (!s.size || !isValidIdentifierBegin(s.data[0])) if (isValidIdentifier(std::string_view{s}))
{ writeString(s, buf);
write_quoted_string(s, buf);
}
else else
{ write_quoted_string(s, buf);
const char * pos = s.data + 1;
const char * end = s.data + s.size;
for (; pos < end; ++pos)
if (!isWordCharASCII(*pos))
break;
if (pos != end)
write_quoted_string(s, buf);
else
writeString(s, buf);
}
} }
void writeProbablyBackQuotedString(const StringRef & s, WriteBuffer & buf) void writeProbablyBackQuotedString(const StringRef & s, WriteBuffer & buf)