thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 00:52:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed regression in parsing of CAST [#CLICKHOUSE-3180].

Browse Source
This commit is contained in:
Alexey Milovidov 2017-07-27 22:25:52 +03:00
parent 3dbde50daa
commit 2c815356c1
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dbms/src/Parsers/ExpressionElementParsers.cpp
View File

@ -300,6 +300,8 @@ bool ParserCastExpression::parseImpl(Pos & pos, ASTPtr & node, Expected & expect
return false; return false;
const auto & id = typeid_cast<const ASTIdentifier &>(*identifier).name; const auto & id = typeid_cast<const ASTIdentifier &>(*identifier).name;
/// TODO This is ridiculous. Please get rid of this.
if (id.length() != strlen(name) || 0 != strcasecmp(id.c_str(), name)) if (id.length() != strlen(name) || 0 != strcasecmp(id.c_str(), name))
{ {
/// Parse as a CASE expression. /// Parse as a CASE expression.
@ -340,6 +342,8 @@ bool ParserCastExpression::parseImpl(Pos & pos, ASTPtr & node, Expected & expect
} }
else else
{ {
pos = contents_begin;
/// CAST(expression, 'type') /// CAST(expression, 'type')
/// Reparse argument list from scratch /// Reparse argument list from scratch
ParserExpressionWithOptionalAlias expression{false}; ParserExpressionWithOptionalAlias expression{false};

2
dbms/tests/queries/0_stateless/00483_cast_syntax.reference Normal file
View File

@ -0,0 +1,2 @@
1
1

2
dbms/tests/queries/0_stateless/00483_cast_syntax.sql Normal file
View File

@ -0,0 +1,2 @@
SELECT CAST(1 AS Int8);
SELECT CAST(1, 'Int8');