thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix UBSan report in arraySum

Browse Source
This commit is contained in:
Alexey Milovidov 2021-01-21 14:42:34 +03:00
parent 110089086b
commit 2cd04e8923
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Functions/array/arrayAggregation.cpp
View File

@ -5,6 +5,7 @@
#include <Columns/ColumnDecimal.h>
#include "FunctionArrayMapped.h"
#include <Functions/FunctionFactory.h>
#include <common/defines.h>
namespace DB
@ -121,7 +122,7 @@ struct ArrayAggregateImpl
}
template <typename Element>
static bool executeType(const ColumnPtr & mapped, const ColumnArray::Offsets & offsets, ColumnPtr & res_ptr)
static NO_SANITIZE_UNDEFINED bool executeType(const ColumnPtr & mapped, const ColumnArray::Offsets & offsets, ColumnPtr & res_ptr)
{
using Result = ArrayAggregateResult<Element, aggregate_operation>;
using ColVecType = std::conditional_t<IsDecimalNumber<Element>, ColumnDecimal<Element>, ColumnVector<Element>>;

1
tests/queries/0_stateless/01659_array_aggregation_ubsan.reference Normal file
View File

@ -0,0 +1 @@
446744073709551616

1
tests/queries/0_stateless/01659_array_aggregation_ubsan.sql Normal file
View File

@ -0,0 +1 @@
SELECT arraySum([-9000000000000000000, -9000000000000000000]);