thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-26 01:22:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Correctly accuire lock

Browse Source
This commit is contained in:
alesapin 2020-02-09 11:42:15 +03:00
parent 5a96eaf0e8
commit 2dca542d2e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
dbms/src/Storages/StorageReplicatedMergeTree.cpp
View File

@ -3272,9 +3272,8 @@ void StorageReplicatedMergeTree::alter(
std::vector<ChangedNode> changed_nodes;
{
/// Just to read current structure. Alter will be done in separate thread.
auto table_lock = lockStructureForShare(false, query_context.getCurrentQueryId());
/// Guard races of alter thread metadata change
lockNewDataStructureExclusively(table_lock_holder, query_context.getCurrentQueryId());
if (is_readonly)
throw Exception("Can't ALTER readonly table", ErrorCodes::TABLE_IS_READ_ONLY);