thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 07:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

rename: S3DiskNoKeyErrors -> DiskS3NoSuchKeyErrors

Browse Source
This commit is contained in:
Michael Stetsyuk 2024-08-14 17:53:33 +00:00
parent 008d02880b
commit 2e5f45a7ad
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Common/CurrentMetrics.cpp
View File

@ -307,7 +307,7 @@
M(FilteringMarksWithPrimaryKey, "Number of threads currently doing filtering of mark ranges by the primary key") \
M(FilteringMarksWithSecondaryKeys, "Number of threads currently doing filtering of mark ranges by secondary keys") \
\
M(S3DiskNoKeyErrors, "The number of `NoSuchKey` errors that occur when reading data from S3 cloud storage through ClickHouse disks.") \
M(DiskS3NoSuchKeyErrors, "The number of `NoSuchKey` errors that occur when reading data from S3 cloud storage through ClickHouse disks.") \
#ifdef APPLY_FOR_EXTERNAL_METRICS
#define APPLY_FOR_METRICS(M) APPLY_FOR_BUILTIN_METRICS(M) APPLY_FOR_EXTERNAL_METRICS(M)

4
src/IO/S3/Client.cpp
View File

@ -46,7 +46,7 @@ namespace ProfileEvents
namespace CurrentMetrics
{
extern const Metric S3DiskNoKeyErrors;
extern const Metric DiskS3NoSuchKeyErrors;
}
namespace DB
@ -701,7 +701,7 @@ RequestResult Client::processRequestResult(RequestResult && outcome) const
return std::forward<RequestResult>(outcome);
if (outcome.GetError().GetErrorType() == Aws::S3::S3Errors::NO_SUCH_KEY)
CurrentMetrics::add(CurrentMetrics::S3DiskNoKeyErrors);
CurrentMetrics::add(CurrentMetrics::DiskS3NoSuchKeyErrors);
String enriched_message = fmt::format(
"{} {}",

2
tests/integration/test_checking_s3_blobs_paranoid/test.py
View File

@ -708,7 +708,7 @@ def test_no_key_found_disk(cluster, broken_s3):
"""
SELECT value
FROM system.metrics
WHERE metric = 'S3DiskNoKeyErrors'
WHERE metric = 'DiskS3NoSuchKeyErrors'
"""
).strip()
)

2
tests/integration/test_storage_delta/test.py
View File

@ -464,7 +464,7 @@ def test_restart_broken(started_cluster):
"""
SELECT value
FROM system.metrics
WHERE metric = 'S3DiskNoKeyErrors'
WHERE metric = 'DiskS3NoSuchKeyErrors'
"""
).strip()
)