thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed stale comment and added log_info about skipped auth methods

Browse Source
This commit is contained in:
Arthur Passos 2024-07-12 10:20:59 -03:00
parent b428327c6e
commit 2e9b7e8334
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/Access/IAccessStorage.cpp
View File

@ -524,15 +524,15 @@ std::optional<AuthResult> IAccessStorage::authenticateImpl(
if (!isAddressAllowed(*user, address))
throwAddressNotAllowed(address);
// for now, just throw exception in case a user exists with invalid auth method
// back in the day, it would also throw an exception. There might be a smarter alternative
// like a user scan during startup.
bool skipped_not_allowed_authentication_methods = false;
for (const auto & auth_method : user->authentication_methods)
{
auto auth_type = auth_method.getType();
if (((auth_type == AuthenticationType::NO_PASSWORD) && !allow_no_password) ||
((auth_type == AuthenticationType::PLAINTEXT_PASSWORD) && !allow_plaintext_password))
{
skipped_not_allowed_authentication_methods = true;
continue;
}
@ -543,6 +543,12 @@ std::optional<AuthResult> IAccessStorage::authenticateImpl(
}
}
if (skipped_not_allowed_authentication_methods)
{
LOG_INFO(log, "Skipped the check for not allowed authentication methods,"
"check allow_no_password and allow_plaintext_password settings in the server configuration");
}
throwInvalidCredentials();
}
}