Merge pull request #48195 from ClickHouse/disable-compile-aggregations

Remove a feature

src/Core/Settings.h

@@ -131,7 +131,7 @@ class IColumn;
     M(Bool, allow_suspicious_fixed_string_types, false, "In CREATE TABLE statement allows creating columns of type FixedString(n) with n > 256. FixedString with length >= 256 is suspicious and most likely indicates misusage", 0) \
     M(Bool, compile_expressions, true, "Compile some scalar functions and operators to native code.", 0) \
     M(UInt64, min_count_to_compile_expression, 3, "The number of identical expressions before they are JIT-compiled", 0) \
-    M(Bool, compile_aggregate_expressions, true, "Compile aggregate functions to native code.", 0) \
+    M(Bool, compile_aggregate_expressions, false, "Compile aggregate functions to native code. This feature has a bug and should not be used.", 0) \
     M(UInt64, min_count_to_compile_aggregate_expression, 3, "The number of identical aggregate expressions before they are JIT-compiled", 0) \
     M(Bool, compile_sort_description, true, "Compile sort description to native code.", 0) \
     M(UInt64, min_count_to_compile_sort_description, 3, "The number of identical sort descriptions before they are JIT-compiled", 0) \

tests/queries/0_stateless/02703_jit_external_aggregation.reference

@@ -0,0 +1 @@
+.....

tests/queries/0_stateless/02703_jit_external_aggregation.sh

@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+# Tags: long, no-asan, no-msan, no-tsan, no-ubsan
+
+CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
+# shellcheck source=../shell_config.sh
+. "$CURDIR"/../shell_config.sh
+
+# This query should return empty result in every of five runs:
+
+for _ in {1..5}
+do
+    $CLICKHOUSE_CLIENT --compile_aggregate_expressions 0 --query "
+SELECT
+    COUNT() AS c,
+    group_key,
+    anyIf(r, key = 0) AS x0,
+    anyIf(r, key = 1) AS x1,
+    anyIf(r, key = 2) AS x2
+FROM
+(
+    SELECT
+        CRC32(toString(number)) % 1000000 AS group_key,
+        number % 3 AS key,
+        number AS r
+    FROM numbers(10000000)
+)
+GROUP BY group_key
+HAVING (c = 2) AND (x0 > 0) AND (x1 > 0) AND (x2 > 0)
+ORDER BY group_key ASC
+LIMIT 10
+SETTINGS max_bytes_before_external_group_by = 200000
+" && echo -n '.'
+done
+
+echo