thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug where empty array always returned if there's any empty array as input

Browse Source
This commit is contained in:
Peter Nguyen 2024-08-27 21:37:08 -06:00
parent d29f0d4c96
commit 3153c0cf96
1 changed files with 11 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/Functions/array/arrayIntersect.cpp
View File

@ -160,13 +160,13 @@ DataTypePtr FunctionArrayIntersect<Mode>::getReturnTypeImpl(const DataTypes & ar
const auto & nested_type = array_type->getNestedType();
if (typeid_cast<const DataTypeNothing *>(nested_type.get()))
has_nothing = true;
// {
// if (std::is_same_v<Mode, ArrayModeIntersect>) {
// has_nothing = true;
// break;
// }
// }
{
if (std::is_same_v<Mode, ArrayModeIntersect>)
{
has_nothing = true;
break;
}
}
else
nested_types.push_back(nested_type);
}
@ -176,13 +176,11 @@ DataTypePtr FunctionArrayIntersect<Mode>::getReturnTypeImpl(const DataTypes & ar
if (!nested_types.empty())
result_type = getMostSubtype(nested_types, true);
if (has_nothing)
// If found any DataTypeNothing in IntersectMode or all DattaTypeNothing in UnionMode
if (has_nothing || nested_types.empty())
result_type = std::make_shared<DataTypeNothing>();
// // If found any DataTypeNothing in IntersectMode or all DattaTypeNothing in UnionMode
// if (has_nothing || nested_types.empty())
// result_type = std::make_shared<DataTypeNothing>();
// else
// result_type = getMostSubtype(nested_types, true);
else
result_type = getMostSubtype(nested_types, true);
return std::make_shared<DataTypeArray>(result_type);
}