thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix doc and comments

Browse Source
This commit is contained in:
kevinyhzou 2024-11-07 20:38:44 +08:00
parent a6b08187b3
commit 3332bce1dc
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/en/sql-reference/functions/type-conversion-functions.md
View File

@ -6880,7 +6880,7 @@ parseDateTime64(str[, [scale, [format[, timezone]]]])
**Arguments**
- `str` — The String to be parsed
- `scale` - The precision for [DateTime64](../data-types/datetime64.md). Optional, default is 6 if not specified.
- `scale` - The precision for [DateTime64](../data-types/datetime64.md). Optional, default 6 if not specified.
- `format` — The format string. Optional. `%Y-%m-%d %H:%i:%s` if not specified.
- `timezone` — [Timezone](/docs/en/operations/server-configuration-parameters/settings.md#timezone). Optional.
@ -6892,7 +6892,7 @@ Returns [DateTime64](../data-types/datetime64.md) type values parsed from input
Same as for [parseDateTime64](#parsedatetime64) except that it returns zero date when it encounters a date format that cannot be processed.
## parseDateTime64OrNull
Same as for [parseDateTime64](#parsedatetime64) except that it returns zero date when it encounters a date format that cannot be processed.
Same as for [parseDateTime64](#parsedatetime64) except that it returns `NULL` when it encounters a date format that cannot be processed.
## parseDateTime64InJodaSyntax
@ -6907,7 +6907,7 @@ parseDateTime64InJodaSyntax(str[, [scale, [format[, timezone]]]])
**Arguments**
- `str` — The String to be parsed
- `scale` - The precision for [DateTime64](../data-types/datetime64.md). Optional, default is 6 if not specified.
- `scale` - The precision for [DateTime64](../data-types/datetime64.md). Optional, default 0 if not specified.
- `format` — The format string. Optional. `yyyy-MM-dd HH:mm:ss` if not specified.
- `timezone` — [Timezone](/docs/en/operations/server-configuration-parameters/settings.md#timezone). Optional.

16
src/Functions/parseDateTime.cpp
View File

@ -65,7 +65,7 @@ namespace
constexpr Int32 minYear = 1970;
constexpr Int32 maxYear = 2106;
constexpr Int32 maxPrecisionOfDateTime64 = 6;
constexpr Int32 maxScaleOfDateTime64 = 6;
const std::unordered_map<String, std::pair<String, Int32>> dayOfWeekMap{
{"mon", {"day", 1}},
@ -193,7 +193,7 @@ namespace
Int32 minute = 0; /// range [0, 59]
Int32 second = 0; /// range [0, 59]
Int32 microsecond = 0; /// range [0, 999999]
UInt32 scale = 0; /// The microsecond scale of DateTime64.
UInt32 scale = 0; /// The scale of DateTime64, range [0, 6].
bool is_am = true; /// If is_hour_of_half_day = true and is_am = false (i.e. pm) then add 12 hours to the result DateTime
bool hour_starts_at_1 = false; /// Whether the hour is clockhour
@ -646,8 +646,8 @@ namespace
scale = col_scale->getValue<UInt8>();
else
throw Exception(ErrorCodes::BAD_ARGUMENTS,
"The input scale value may exceed the max value of `DateTime64`: {}.",
maxPrecisionOfDateTime64);
"The input scale value may exceed the max scale value of `DateTime64`: {}.",
maxScaleOfDateTime64);
}
else
{
@ -656,7 +656,7 @@ namespace
}
/// Construct the return type `DataTypDateTime64` with scale and time zone name. The scale value can be specified or be extracted
/// from the format string by counting how many 'S' characters are contained in the format's micorsceond fragment.
/// from the format string by counting how many 'S' characters are contained in the format's microsceond fragment.
String format = getFormat(arguments, scale);
std::vector<Instruction> instructions = parseFormat(format);
for (const auto & instruction : instructions)
@ -683,11 +683,11 @@ namespace
else if (scale == 0 && val != 0)
scale = val;
}
if (scale > maxPrecisionOfDateTime64)
if (scale > maxScaleOfDateTime64)
throw Exception(ErrorCodes::BAD_ARGUMENTS,
"The scale of the input format string {} exceed the max scale value {}.",
format,
maxPrecisionOfDateTime64);
maxScaleOfDateTime64);
}
data_type = std::make_shared<DataTypeDateTime64>(scale, time_zone_name);
}
@ -1398,7 +1398,7 @@ namespace
if (date.scale != 6)
RETURN_ERROR(
ErrorCodes::CANNOT_PARSE_DATETIME,
"Unable to parse fragment {} from {} because of the microsecond's scale {} is not 6",
"Unable to parse fragment {} from {} because of the datetime scale {} is not 6",
fragment,
std::string_view(cur, end - cur),
std::to_string(date.scale))