thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix possible segfault in schema inference for JSON formats

Browse Source
This commit is contained in:
avogar 2022-04-13 12:34:40 +00:00
parent 71dc0f0616
commit 348cae0d16
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Formats/JSONEachRowUtils.cpp
View File

@ -255,6 +255,10 @@ struct JSONEachRowFieldsExtractor
std::vector<Element> extract(const Element & element)
{
/// {..., "<column_name>" : <value>, ...}
if (!element.isObject())
throw Exception(ErrorCodes::INCORRECT_DATA, "Root JSON value is not an object");
auto object = element.getObject();
std::vector<Element> fields;
fields.reserve(object.size());
@ -287,6 +291,9 @@ struct JSONCompactEachRowFieldsExtractor
std::vector<Element> extract(const Element & element)
{
/// [..., <value>, ...]
if (!element.isArray())
throw Exception(ErrorCodes::INCORRECT_DATA, "Root JSON value is not an array");
auto array = element.getArray();
std::vector<Element> fields;
fields.reserve(array.size());

0
tests/queries/0_stateless/02268_json_wrong_root_type_in_schema_inference.reference Normal file
View File

8
tests/queries/0_stateless/02268_json_wrong_root_type_in_schema_inference.sql Normal file
View File

@ -0,0 +1,8 @@
-- Tags: no-backward-compatibility-check:22.4.1.1
insert into function file('02268_data.jsonl', 'TSV') select 1;
select * from file('02268_data.jsonl'); --{serverError CANNOT_EXTRACT_TABLE_STRUCTURE}
insert into function file('02268_data.jsonCompactEachRow', 'TSV') select 1;
select * from file('02268_data.jsonCompactEachRow'); --{serverError CANNOT_EXTRACT_TABLE_STRUCTURE}