thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

removed redundant lines and comments

Browse Source
This commit is contained in:
Артем Стрельцов 2020-05-03 00:49:19 +03:00
parent c82b1fc0fe
commit 359de11fee
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Dictionaries/DirectDictionary.cpp
View File

@ -483,23 +483,18 @@ void DirectDictionary::getItemsStringImpl(
for (const auto row_idx : ext::range(0, id_column.size()))
{
const auto key = id_column[row_idx].get<UInt64>();
// for (const auto row : ext::range(0, rows))
// {
if (key == ids[row] && attribute.name == attribute_name_by_index.at(attribute_idx))
{
is_found[row] = true;
const String from_source = attribute_column[row_idx].get<String>();
set_value(row, from_source);
}
// }
if (key == ids[row] && attribute.name == attribute_name_by_index.at(attribute_idx))
{
is_found[row] = true;
const String from_source = attribute_column[row_idx].get<String>();
set_value(row, from_source);
}
}
}
}
stream->readSuffix();
}
for (const auto row : ext::range(0, rows))
if (!is_found[row])
set_value(row, get_default(row));
@ -587,7 +582,6 @@ void registerDictionaryDirect(DictionaryFactory & factory)
const std::string & config_prefix,
DictionarySourcePtr source_ptr) -> DictionaryPtr
{
/// idk should my?
if (dict_struct.key)
throw Exception{"'key' is not supported for dictionary of layout 'direct'", ErrorCodes::UNSUPPORTED_METHOD};