thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

AggregateFunctionSumMap better comment message

Browse Source
This commit is contained in:
Maksim Kita 2021-03-01 19:15:59 +03:00
parent 56af09891b
commit 3764a2a2be
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/AggregateFunctions/AggregateFunctionSumMap.h
View File

@ -118,6 +118,8 @@ public:
WhichDataType value_type_to_check(value_type);
/// Do not promote decimal because of implementation issues of this function design
/// Currently we cannot get result column type in case of decimal we cannot get decimal scale
/// in method void insertResultInto(AggregateDataPtr __restrict place, IColumn & to, Arena *) const override
/// If we decide to make this function more efficient we should promote decimal type during summ
if (value_type_to_check.isDecimal())
result_type = value_type_without_nullable;
@ -337,7 +339,11 @@ public:
if (elem.second[col].isNull())
to_values_col.insertDefault();
else
{
auto element_field = elem.second[col];
to_values_col.insert(elem.second[col]);
}
}
}
}