From 393cab820e479a76710d691d1da825079307847a Mon Sep 17 00:00:00 2001 From: taiyang-li <654010905@qq.com> Date: Wed, 24 Jan 2024 18:48:29 +0800 Subject: [PATCH] add some comment --- src/Functions/if.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Functions/if.cpp b/src/Functions/if.cpp index bb71f3ff1d9..f10b9989f13 100644 --- a/src/Functions/if.cpp +++ b/src/Functions/if.cpp @@ -261,7 +261,7 @@ struct NumIfImpl auto col_res = ColVecResult::create(size); ArrayResult & res = col_res->getData(); - /// TODO 这里是否可避免分支跳转 + /// TODO cast a and b only once for (size_t i = 0; i < size; ++i) res[i] = cond[i] ? static_cast(a) : static_cast(b); return col_res; @@ -1185,7 +1185,7 @@ public: } else { - /// TODO 这里不物化行不行? + /// TODO why materialize condition materialized_cond_col = cond_const_col->convertToFullColumn(); cond_col = typeid_cast(&*materialized_cond_col); }