dbms, contrib: Clang 3.8 build fixes. [#METR-21516]

contrib/libpoco/Crypto/include/Poco/Crypto/Crypto.h

@@ -22,6 +22,7 @@
 #define Crypto_Crypto_INCLUDED
 
 
+#pragma GCC diagnostic push
 #if defined(__APPLE__)
 // OS X 10.7 deprecates some OpenSSL functions
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations" 
@@ -115,5 +116,6 @@ void Crypto_API uninitializeCrypto();
 
 } } // namespace Poco::Crypto
 
+#pragma GCC diagnostic pop
 
 #endif // Crypto_Crypto_INCLUDED

contrib/libpoco/Data/include/Poco/Data/Binding.h

@@ -34,6 +34,10 @@
 #include <map>
 #include <cstddef>
 
+#pragma GCC diagnostic push
+#ifdef __clang__
+#pragma GCC diagnostic ignored "-Wunused-local-typedef"
+#endif
 
 namespace Poco {
 namespace Data {
@@ -1495,4 +1499,6 @@ inline AbstractBinding::Ptr bind(T t)
 } } // namespace Poco::Data
 
 
+#pragma GCC diagnostic pop
+
 #endif // Data_Binding_INCLUDED

contrib/libpoco/Foundation/include/Poco/Dynamic/VarHolder.h

@@ -44,6 +44,11 @@
 #include <limits>
 
 
+#pragma GCC diagnostic push
+#ifdef __clang__
+#pragma GCC diagnostic ignored "-Wunused-local-typedef"
+#endif
+
 namespace Poco {
 namespace Dynamic {
 
@@ -3550,5 +3555,6 @@ typedef Vector           Array;
 
 } } // namespace Poco::Dynamic
 
+#pragma GCC diagnostic pop
 
 #endif // Foundation_VarHolder_INCLUDED

contrib/libpoco/Net/src/IPAddressImpl.cpp

@@ -22,6 +22,7 @@
 #include "Poco/String.h"
 #include "Poco/Types.h"
 
+#pragma GCC diagnostic push
 #if __GNUC__ > 5
 #pragma GCC diagnostic ignored "-Wmisleading-indentation"
 #endif
@@ -811,3 +812,5 @@ bool IPv6AddressImpl::operator != (const IPv6AddressImpl& addr) const
 
 
 } } } // namespace Poco::Net::Impl
+
+#pragma GCC diagnostic pop

contrib/libpoco/NetSSL_OpenSSL/src/Session.cpp

@@ -14,6 +14,7 @@
 //
 
 
+#pragma GCC diagnostic push
 #if defined(__APPLE__)
 // Some OpenSSL functions are deprecated in OS X 10.7
 #pragma GCC diagnostic ignored "-Wdeprecated-declarations" 
@@ -40,3 +41,5 @@ Session::~Session()
 
 
 } } // namespace Poco::Net
+
+#pragma GCC diagnostic pop

contrib/libtcmalloc/src/base/elf_mem_image.cc

@@ -54,6 +54,9 @@
 
 #define VERSYM_VERSION 0x7fff
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-const-variable"
+
 namespace base {
 
 namespace {
@@ -431,4 +434,6 @@ void ElfMemImage::SymbolIterator::Update(int increment) {
 
 }  // namespace base
 
+#pragma GCC diagnostic pop
+
 #endif  // HAVE_ELF_MEM_IMAGE

contrib/libtcmalloc/src/debugallocation.cc

@@ -97,6 +97,12 @@
 # define MAP_ANONYMOUS MAP_ANON
 #endif
 
+#pragma GCC diagnostic push
+#ifdef __clang__
+#pragma GCC diagnostic ignored "-Wunused-private-field"
+#pragma GCC diagnostic ignored "-Wgnu-alignof-expression"
+#endif
+
 // ========================================================================= //
 
 DEFINE_bool(malloctrace,
@@ -1488,3 +1494,5 @@ extern "C" PERFTOOLS_DLL_DECL void* tc_malloc_skip_new_handler(size_t size) PERF
   MallocHook::InvokeNewHook(result, size);
   return result;
 }
+
+#pragma GCC diagnostic pop

contrib/libtcmalloc/src/system-alloc.cc

@@ -56,9 +56,8 @@
 #include "common.h"
 #include "internal_logging.h"
 
-#ifdef __GNUC__
+#pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wunused-function"
-#endif
 
 // On systems (like freebsd) that don't define MAP_ANONYMOUS, use the old
 // form of the name instead.
@@ -564,3 +563,5 @@ void TCMalloc_SystemCommit(void* start, size_t length) {
   // such that they need to be re-committed before they can be used by the
   // application.
 }
+
+#pragma GCC diagnostic pop

contrib/libtcmalloc/src/tcmalloc.cc

@@ -155,6 +155,9 @@ using STL_NAMESPACE::vector;
 
 #include "libc_override.h"
 
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-function"
+
 using tcmalloc::AlignmentForSize;
 using tcmalloc::kLog;
 using tcmalloc::kCrash;
@@ -1834,4 +1837,6 @@ extern "C" PERFTOOLS_DLL_DECL void* tc_malloc_skip_new_handler(size_t size)  PER
   return result;
 }
 
+#pragma GCC diagnostic pop
+
 #endif  // TCMALLOC_USING_DEBUGALLOCATION

dbms/include/DB/Functions/Conditional/ArrayEvaluator.h

@@ -172,7 +172,7 @@ public:
 			converted = std::make_unique<PaddedPODArray<TResult> >(array.size());
 			size_t size = array.size();
 			for (size_t i = 0; i < size; ++i)
-				(*converted)[i] = array[i].get<typename NearestFieldType<TType>::Type>();
+				(*converted)[i] = array[i].template get<typename NearestFieldType<TType>::Type>();
 		}
 
 		return {converted->data(), converted->size()};

dbms/include/DB/Storages/Distributed/DirectoryMonitor.h

@@ -58,7 +58,7 @@ namespace
 					ErrorCodes::INCORRECT_FILE_NAME
 				};
 
-			const auto user = unescapeForFileName({address.data(), has_pw ? colon : user_pw_end});
+			const auto user = unescapeForFileName({address.data(), has_pw ? static_cast<const char *>(colon) : user_pw_end});
 			const auto password = has_pw ? unescapeForFileName({colon + 1, user_pw_end}) : std::string{};
 			const auto host = unescapeForFileName({user_pw_end + 1, host_end});
 			const auto port = parse<UInt16>(host_end + 1);

dbms/include/DB/Storages/MergeTree/RemotePartChecker.h

@@ -46,7 +46,7 @@ public:
 		const InterserverIOEndpointLocation & to_location);
 
 private:
-	Logger * log = &Logger::get("RemotePartChecker::Client");
+//	Logger * log = &Logger::get("RemotePartChecker::Client");
 };
 
 }

dbms/src/Databases/DatabaseOrdinary.cpp

@@ -230,7 +230,7 @@ public:
 		return it->first;
 	}
 
-	StoragePtr & table() const
+	StoragePtr & table() const override
 	{
 		return it->second;
 	}

dbms/src/Functions/Conditional/ArgsInfo.cpp

@@ -45,7 +45,7 @@ std::string dumpArgTypes(const DataTypes & args)
 
 /// Forward declarations.
 template <typename TResult, typename TType>
-struct ResultDataTypeDeducer;
+class ResultDataTypeDeducer;
 
 /// Internal class used by ResultDataTypeDeducer. Calls ResultDataTypeDeducer
 /// for the next branch to be processed.

dbms/src/Functions/Conditional/StringArrayEvaluator.cpp

@@ -184,12 +184,12 @@ public:
 	{
 	}
 
-	size_t getDataSize() const
+	size_t getDataSize() const override
 	{
 		return data_size;
 	}
 
-	size_t getStringOffsetsSize() const
+	size_t getStringOffsetsSize() const override
 	{
 		return data.size();
 	}

dbms/src/Functions/Conditional/StringEvaluator.cpp

@@ -143,7 +143,7 @@ public:
 		return chunk;
 	}
 
-	inline size_t getSize() const
+	inline size_t getSize() const override
 	{
 		return size;
 	}

dbms/src/Functions/Conditional/getArrayType.cpp

@@ -37,7 +37,7 @@ std::string dumpArgTypes(const DataTypes & args)
 
 /// Forward declarations.
 template <typename TResult, typename TType>
-struct ResultDataTypeDeducer;
+class ResultDataTypeDeducer;
 
 /// Internal class used by ResultDataTypeDeducer. Calls ResultDataTypeDeducer
 /// for the next element to be processed.

dbms/src/IO/tests/io_and_exceptions.cpp

@@ -13,9 +13,8 @@
   */
 
 /// В этом тесте намеренно ссылаемся за пределы массива.
-#ifdef __GNUC__
+#pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Warray-bounds"
-#endif
 
 using size_t = unsigned long;
 
@@ -161,3 +160,5 @@ void f()
 {
 	parse("123");
 }
+
+#pragma GCC diagnostic pop