thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-10 09:32:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Bump librdkafka to fix UB in snappy decompression.

Browse Source 
In incremental_copy_fast_path there is undefined behavior (and in some
other places too).

And under this circumstances gcc10 with -O1 -ftree-loop-vectorize (or
simply -O3), due to loop unroll, generates code that do copy by 16 bytes
at a time for the second loop (MOVDQU+MOVUPS), while this is not correct
since the memory may be overlapped and may be changed in the previous
iteration.

Updated version includes [1], that fixes those UB, by using memcpy over
direct store/load since these days direct store/loads looks redundant.
Even on ARM.

  [1]: https://github.com/ClickHouse-Extras/librdkafka/pull/3

NOTE: clang is fine, and other older versions of gcc too
This commit is contained in:
Azat Khuzhin 2020-12-14 00:34:38 +03:00
parent 2e569899d1
commit 3b431b054e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/librdkafka vendored

@ -1 +1 @@
Subproject commit 9902bc4fb18bb441fa55ca154b341cdda191e5d3
Subproject commit f2f6616419d567c9198aef0d1133a2e9b4f02276