thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

dbms: style [#METR-12108].

Browse Source
This commit is contained in:
Alexey Milovidov 2014-08-20 03:12:31 +04:00
parent 2174548c76
commit 3b8c4d2c9d
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dbms/src/Interpreters/ExpressionAnalyzer.cpp
View File

@ -40,7 +40,8 @@ namespace DB
/** Calls to these functions in the GROUP BY statement would be /** Calls to these functions in the GROUP BY statement would be
* replaced by their immediate argument. * replaced by their immediate argument.
*/ */
const std::unordered_set<String> injectiveFunctionNames{ const std::unordered_set<String> injective_function_names
{
"negate", "negate",
"bitNot", "bitNot",
"reverse", "reverse",
@ -68,7 +69,7 @@ void ExpressionAnalyzer::init()
/// Common subexpression elimination. Rewrite rules. /// Common subexpression elimination. Rewrite rules.
normalizeTree(); normalizeTree();
/// GROUP BY injective function elimination /// GROUP BY injective function elimination.
optimizeGroupBy(); optimizeGroupBy();
/// array_join_alias_to_name, array_join_result_to_source. /// array_join_alias_to_name, array_join_result_to_source.
@ -455,7 +456,8 @@ void ExpressionAnalyzer::optimizeGroupBy()
auto & group_exprs = select_query->group_expression_list->children; auto & group_exprs = select_query->group_expression_list->children;
/// removes expression at index idx by making it last one and calling .pop_back() /// removes expression at index idx by making it last one and calling .pop_back()
const auto remove_expr_at_index = [&group_exprs] (const size_t idx) { const auto remove_expr_at_index = [&group_exprs] (const size_t idx)
{
if (idx < group_exprs.size() - 1) if (idx < group_exprs.size() - 1)
group_exprs[idx] = std::move(group_exprs.back()); group_exprs[idx] = std::move(group_exprs.back());
@ -468,7 +470,7 @@ void ExpressionAnalyzer::optimizeGroupBy()
if (const auto function = typeid_cast<ASTFunction*>(group_exprs[i].get())) if (const auto function = typeid_cast<ASTFunction*>(group_exprs[i].get()))
{ {
/// assert function is injective /// assert function is injective
if (!injectiveFunctionNames.count(function->name)) if (!injective_function_names.count(function->name))
{ {
++i; ++i;
continue; continue;