thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-02 20:42:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy report issues with Medium priority

Browse Source
This commit is contained in:
Rajkumar 2022-03-10 07:23:49 -08:00
parent af4362e40a
commit 3d3b6d1956
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Interpreters/InterpreterCreateQuery.cpp
View File

@ -1062,7 +1062,7 @@ BlockIO InterpreterCreateQuery::createTable(ASTCreateQuery & create)
QualifiedTableName qualified_name{database_name, create.getTable()}; QualifiedTableName qualified_name{database_name, create.getTable()};
TableNamesSet loading_dependencies = getDependenciesSetFromCreateQuery(getContext()->getGlobalContext(), qualified_name, query_ptr); TableNamesSet loading_dependencies = getDependenciesSetFromCreateQuery(getContext()->getGlobalContext(), qualified_name, query_ptr);
if (!loading_dependencies.empty()) if (!loading_dependencies.empty())
DatabaseCatalog::instance().addLoadingDependencies(std::move(qualified_name), std::move(loading_dependencies)); DatabaseCatalog::instance().addLoadingDependencies(qualified_name, std::move(loading_dependencies));
return fillTableIfNeeded(create); return fillTableIfNeeded(create);
} }

2
src/Interpreters/InterpreterInsertQuery.cpp
View File

@ -185,7 +185,7 @@ Chain InterpreterInsertQuery::buildChain(
std::atomic_uint64_t * elapsed_counter_ms) std::atomic_uint64_t * elapsed_counter_ms)
{ {
auto sample = getSampleBlock(columns, table, metadata_snapshot); auto sample = getSampleBlock(columns, table, metadata_snapshot);
return buildChainImpl(table, metadata_snapshot, std::move(sample) , thread_status, elapsed_counter_ms); return buildChainImpl(table, metadata_snapshot, sample, thread_status, elapsed_counter_ms);
} }
Chain InterpreterInsertQuery::buildChainImpl( Chain InterpreterInsertQuery::buildChainImpl(

2
src/Interpreters/SystemLog.cpp
View File

@ -332,7 +332,7 @@ void SystemLog<LogElement>::flushImpl(const std::vector<LogElement> & to_flush,
for (const auto & name_and_type : log_element_names_and_types) for (const auto & name_and_type : log_element_names_and_types)
log_element_columns.emplace_back(name_and_type.type, name_and_type.name); log_element_columns.emplace_back(name_and_type.type, name_and_type.name);
Block block(std::move(log_element_columns)); Block block(log_element_columns);
MutableColumns columns = block.mutateColumns(); MutableColumns columns = block.mutateColumns();
for (const auto & elem : to_flush) for (const auto & elem : to_flush)

4
src/Storages/ColumnsDescription.cpp
View File

@ -122,7 +122,7 @@ void ColumnDescription::readText(ReadBuffer & buf)
if (col_ast->default_expression) if (col_ast->default_expression)
{ {
default_desc.kind = columnDefaultKindFromString(col_ast->default_specifier); default_desc.kind = columnDefaultKindFromString(col_ast->default_specifier);
default_desc.expression = std::move(col_ast->default_expression); default_desc.expression = col_ast->default_expression;
} }
if (col_ast->comment) if (col_ast->comment)
@ -309,7 +309,7 @@ void ColumnsDescription::flattenNested()
continue; continue;
} }
ColumnDescription column = std::move(*it); ColumnDescription column = *it;
removeSubcolumns(column.name); removeSubcolumns(column.name);
it = columns.get<0>().erase(it); it = columns.get<0>().erase(it);

2
src/Storages/StorageDistributed.h
View File

@ -43,7 +43,7 @@ class StorageDistributed final : public shared_ptr_helper<StorageDistributed>, p
friend class StorageSystemDistributionQueue; friend class StorageSystemDistributionQueue;
public: public:
~StorageDistributed() override; virtual ~StorageDistributed() override;
std::string getName() const override { return "Distributed"; } std::string getName() const override { return "Distributed"; }