thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use writeRetry in case of exception during writing to the log

Browse Source
This commit is contained in:
Azat Khuzhin 2021-06-02 08:01:09 +03:00
parent 8ec874dc33
commit 3d9218dbfa
1 changed files with 20 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
base/loggers/OwnSplitChannel.cpp
View File

@ -11,6 +11,7 @@
#include <Common/DNSResolver.h> #include <Common/DNSResolver.h>
#include <common/getThreadId.h> #include <common/getThreadId.h>
#include <Common/SensitiveDataMasker.h> #include <Common/SensitiveDataMasker.h>
#include <Common/IO.h>
namespace DB namespace DB
{ {
@ -43,34 +44,31 @@ void OwnSplitChannel::tryLogSplit(const Poco::Message & msg)
{ {
logSplit(msg); logSplit(msg);
} }
/// It is better to catch the errors here in order to avoid
/// breaking some functionality because of unexpected "File not
/// found" (or similar) error.
///
/// For example StorageDistributedDirectoryMonitor will mark batch
/// as broken, some MergeTree code can also be affected.
///
/// Also note, that we cannot log the exception here, since this
/// will lead to recursion, using regular tryLogCurrentException().
/// but let's log it into the stderr at least.
catch (...) catch (...)
{ {
MemoryTracker::LockExceptionInThread lock_memory_tracker(VariableContext::Global); MemoryTracker::LockExceptionInThread lock_memory_tracker(VariableContext::Global);
/// It is better to catch the errors here in order to avoid const std::string & exception_message = getCurrentExceptionMessage(true);
/// breaking some functionality because of unexpected "File not const std::string & message = msg.getText();
/// found" (or similar) error.
///
/// For example StorageDistributedDirectoryMonitor will mark batch
/// as broken, some MergeTree code can also be affected.
///
/// Also note, that we cannot log the exception here, since this
/// will lead to recursion, using regular tryLogCurrentException().
/// but let's log it into the stderr at least.
std::string message = "Cannot add message to the log:\n";
message += msg.getText();
message += "\n";
message += getCurrentExceptionMessage(true);
try if (!writeRetry(STDERR_FILENO, "Cannot add message to the log: ") ||
!writeRetry(STDERR_FILENO, message.data(), message.size()) ||
!writeRetry(STDERR_FILENO, "\n") ||
!writeRetry(STDERR_FILENO, exception_message.data(), exception_message.size()) ||
!writeRetry(STDERR_FILENO, "\n")
)
{ {
WriteBufferFromFileDescriptor out(STDERR_FILENO, 4096); /// Nothing can be done. Ignore the error.
writeBinary(message, out);
out.finalize();
}
catch (...)
{
/// Nothing can be done. Ignore the exception.
} }
} }
} }