thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-24 08:32:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cosmetics

Browse Source
This commit is contained in:
Robert Schulze 2024-04-15 10:57:00 +00:00
parent 8c9f89a2f5
commit 3db2cbef73
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/Functions/parseDateTime.cpp
View File

@ -594,9 +594,6 @@ namespace
/// Make datetime fit in a cache line. /// Make datetime fit in a cache line.
alignas(64) DateTime<error_handling> datetime; alignas(64) DateTime<error_handling> datetime;
/// Catching and ignoring exceptions after throwing them in the loop below is prohibited can cause serious concurrency performance issues.
/// Use tl::expected to handle the error situation.
/// Usage reference https://en.cppreference.com/w/cpp/utility/expected
for (size_t i = 0; i < input_rows_count; ++i) for (size_t i = 0; i < input_rows_count; ++i)
{ {
datetime.reset(); datetime.reset();
@ -607,7 +604,11 @@ namespace
for (const auto & instruction : instructions) for (const auto & instruction : instructions)
{ {
if (auto result = instruction.perform(cur, end, datetime); !result.has_value()) if (auto result = instruction.perform(cur, end, datetime); result.has_value())
{
cur = *result;
}
else
{ {
if constexpr (error_handling == ErrorHandling::Zero) if constexpr (error_handling == ErrorHandling::Zero)
{ {
@ -625,11 +626,10 @@ namespace
else else
{ {
static_assert(error_handling == ErrorHandling::Exception); static_assert(error_handling == ErrorHandling::Exception);
throw Exception(result.error().error_code, "{}", result.error().error_message); const ErrorCodeAndMessage & err = result.error();
throw Exception(err.error_code, "{}", err.error_message);
} }
} }
else
cur = *result;
} }
if (error) if (error)