thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-26 09:32:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix div by zero in decimal var/stddev

Browse Source
This commit is contained in:
chertus 2018-09-26 15:38:36 +03:00
parent b48402e871
commit 3ff2cfb4af
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dbms/src/AggregateFunctions/AggregateFunctionStatisticsSimple.h
View File

@ -116,9 +116,12 @@ struct VarMomentsDecimal
Float64 getPopulation(UInt32 scale) const Float64 getPopulation(UInt32 scale) const
{ {
if (m0 == 0)
return std::numeric_limits<Float64>::infinity();
NativeType tmp; NativeType tmp;
if (common::mulOverflow(m1, m1, tmp) || if (common::mulOverflow(m1, m1, tmp) ||
common::subOverflow(m2, NativeType(tmp/m0), tmp)) common::subOverflow(m2, NativeType(tmp / m0), tmp))
throw Exception("Decimal math overflow", ErrorCodes::DECIMAL_OVERFLOW); throw Exception("Decimal math overflow", ErrorCodes::DECIMAL_OVERFLOW);
return convertFromDecimal<DataTypeDecimal<T>, DataTypeNumber<Float64>>(tmp / m0, scale); return convertFromDecimal<DataTypeDecimal<T>, DataTypeNumber<Float64>>(tmp / m0, scale);
} }
@ -126,11 +129,13 @@ struct VarMomentsDecimal
Float64 getSample(UInt32 scale) const Float64 getSample(UInt32 scale) const
{ {
if (m0 == 0) if (m0 == 0)
return std::numeric_limits<T>::quiet_NaN(); return std::numeric_limits<Float64>::quiet_NaN();
if (m0 == 1)
return std::numeric_limits<Float64>::infinity();
NativeType tmp; NativeType tmp;
if (common::mulOverflow(m1, m1, tmp) || if (common::mulOverflow(m1, m1, tmp) ||
common::subOverflow(m2, NativeType(tmp/m0), tmp)) common::subOverflow(m2, NativeType(tmp / m0), tmp))
throw Exception("Decimal math overflow", ErrorCodes::DECIMAL_OVERFLOW); throw Exception("Decimal math overflow", ErrorCodes::DECIMAL_OVERFLOW);
return convertFromDecimal<DataTypeDecimal<T>, DataTypeNumber<Float64>>(tmp / (m0 - 1), scale); return convertFromDecimal<DataTypeDecimal<T>, DataTypeNumber<Float64>>(tmp / (m0 - 1), scale);
} }