thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix stacktrace cache

Browse Source
This commit is contained in:
Antonio Andelic 2024-07-26 09:33:46 +02:00
parent da24aa06fa
commit 400f8e5b21
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Common/StackTrace.cpp
View File

@ -495,18 +495,19 @@ using StackTraceCacheBase = std::map<StackTraceTriple, CacheEntryPtr, std::less<
struct StackTraceCache : public StackTraceCacheBase struct StackTraceCache : public StackTraceCacheBase
{ {
StackTraceCache()
: StackTraceCacheBase()
{
can_use_cache = true;
}
~StackTraceCache() ~StackTraceCache()
{ {
can_use_cache = false; can_use_cache = false;
} }
}; };
static StackTraceCache & cacheInstance() static StackTraceCache cache;
{
static StackTraceCache cache;
can_use_cache = true;
return cache;
}
static DB::SharedMutex stacktrace_cache_mutex; static DB::SharedMutex stacktrace_cache_mutex;
@ -524,7 +525,6 @@ String toStringCached(const StackTrace::FramePointers & pointers, size_t offset,
/// Calculation of stack trace text is extremely slow. /// Calculation of stack trace text is extremely slow.
/// We use cache because otherwise the server could be overloaded by trash queries. /// We use cache because otherwise the server could be overloaded by trash queries.
/// Note that this cache can grow unconditionally, but practically it should be small. /// Note that this cache can grow unconditionally, but practically it should be small.
StackTraceCache & cache = cacheInstance();
CacheEntryPtr cache_entry; CacheEntryPtr cache_entry;
// Optimistic try for cache hit to avoid any contention whatsoever, should be the main hot code route // Optimistic try for cache hit to avoid any contention whatsoever, should be the main hot code route
@ -576,7 +576,7 @@ std::string StackTrace::toString(void * const * frame_pointers_raw, size_t offse
void StackTrace::dropCache() void StackTrace::dropCache()
{ {
std::lock_guard lock{stacktrace_cache_mutex}; std::lock_guard lock{stacktrace_cache_mutex};
cacheInstance().clear(); cache.clear();
} }