Apply suggestions from code review

Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
This commit is contained in:
Anton Popov 2023-09-05 13:03:15 +02:00
parent 77111a229d
commit 401496aa1f
2 changed files with 2 additions and 1 deletions

View File

@ -837,6 +837,7 @@ Pipe ReadFromMergeTree::spreadMarkRangesAmongStreamsWithOrder(
};
Pipes pipes;
/// For parallel replicas the split will be performed on the initiator side.
if (is_parallel_reading_from_replicas)
{
pipes.emplace_back(readInOrder(std::move(parts_with_ranges), column_names, pool_settings, read_type, input_order_info->limit));

View File

@ -22,7 +22,7 @@ public:
virtual bool preservesOrderOfRanges() const = 0;
/// task_idx is an implementation defined identifier that helps
/// to get required task. E.g. it may be number of thread, index of
/// to get required task. E.g. it may be number of thread in case of Default reading type or an index of a part in case of InOrder/InReverseOrder reading type.
virtual MergeTreeReadTaskPtr getTask(size_t task_idx, MergeTreeReadTask * previous_task) = 0;
virtual void profileFeedback(ReadBufferFromFileBase::ProfileInfo info) = 0;
};