thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added fstat for table fd + more fixes

Browse Source
This commit is contained in:
BoloniniD 2021-07-09 12:20:11 +03:00
parent 0f584c3e76
commit 407652457f
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/Storages/StorageFile.cpp
View File

@ -57,6 +57,7 @@ namespace ErrorCodes
extern const int TIMEOUT_EXCEEDED;
extern const int INCOMPATIBLE_COLUMNS;
extern const int CANNOT_READ_FROM_FILE_DESCRIPTOR;
extern const int CANNOT_STAT;
}
namespace
@ -500,21 +501,25 @@ Pipe StorageFile::read(
// if we do multiple reads from pipe, we want to check if pipe is a regular file or a pipe
if (this_ptr->table_fd_was_used)
{
if (S_ISREG(this_ptr->table_fd))
struct stat fd_stat;
if (fstat(this_ptr->table_fd, &fd_stat) == -1)
{
throw Exception("Cannot stat table file descriptor, inside " + this_ptr->getName(), ErrorCodes::CANNOT_STAT);
}
if (S_ISREG(fd_stat.st_mode))
{
if (this_ptr->table_fd_init_offset < 0)
{
throw Exception("File descriptor isn't seekable, inside " + this_ptr->getName(), ErrorCodes::CANNOT_SEEK_THROUGH_FILE);
}
int seekable_table_fd = dup(this_ptr->table_fd);
if (lseek(seekable_table_fd, this_ptr->table_fd_init_offset, SEEK_SET) < 0)
if (lseek(this_ptr->table_fd, this_ptr->table_fd_init_offset, SEEK_SET) < 0)
{
throw Exception("File descriptor isn't seekable, inside " + this_ptr->getName(), ErrorCodes::CANNOT_SEEK_THROUGH_FILE);
}
}
else
{
// else if fd is a pipeline, then throw an Exception
// else if fd is not a regular file, then throw an Exception
throw Exception("Cannot read from a pipeline twice", ErrorCodes::CANNOT_READ_FROM_FILE_DESCRIPTOR);
}
}