mirror of
https://github.com/ClickHouse/ClickHouse.git
synced 2024-11-26 17:41:59 +00:00
Rewrite tryPushDownFilter for join with lambda
This commit is contained in:
parent
549a85fee9
commit
4124dc9ac4
@ -1,3 +1,10 @@
|
||||
#include <Columns/IColumn.h>
|
||||
|
||||
#include <Common/logger_useful.h>
|
||||
#include <Common/typeid_cast.h>
|
||||
|
||||
#include <DataTypes/DataTypeAggregateFunction.h>
|
||||
|
||||
#include <Processors/QueryPlan/Optimizations/Optimizations.h>
|
||||
#include <Processors/QueryPlan/ITransformingStep.h>
|
||||
#include <Processors/QueryPlan/FilterStep.h>
|
||||
@ -11,13 +18,10 @@
|
||||
#include <Processors/QueryPlan/TotalsHavingStep.h>
|
||||
#include <Processors/QueryPlan/DistinctStep.h>
|
||||
#include <Processors/QueryPlan/UnionStep.h>
|
||||
|
||||
#include <Interpreters/ActionsDAG.h>
|
||||
#include <Interpreters/ArrayJoinAction.h>
|
||||
#include <Interpreters/TableJoin.h>
|
||||
#include <Common/typeid_cast.h>
|
||||
#include <DataTypes/DataTypeAggregateFunction.h>
|
||||
|
||||
#include <Columns/IColumn.h>
|
||||
|
||||
namespace DB::ErrorCodes
|
||||
{
|
||||
@ -215,22 +219,18 @@ size_t tryPushDownFilter(QueryPlan::Node * parent_node, QueryPlan::Nodes & nodes
|
||||
}
|
||||
|
||||
if (auto * join = typeid_cast<JoinStep *>(child.get()))
|
||||
{
|
||||
auto join_push_down = [&](ASTTableJoin::Kind kind) -> size_t
|
||||
{
|
||||
const auto & table_join = join->getJoin()->getTableJoin();
|
||||
std::vector<ASTTableJoin::Kind> kinds = {ASTTableJoin::Kind::Left};
|
||||
|
||||
/// For not full sorting merge join push down is for left table only, because left and right streams are not independent.
|
||||
/// Only inner and left(/right) join are supported. Other types may generate default values for left table keys.
|
||||
/// So, if we push down a condition like `key != 0`, not all rows may be filtered.
|
||||
if (join->allowPushDownToRight())
|
||||
kinds.emplace_back(ASTTableJoin::Kind::Right);
|
||||
if (table_join.kind() != ASTTableJoin::Kind::Inner && table_join.kind() != kind)
|
||||
return 0;
|
||||
|
||||
for (const auto kind : kinds)
|
||||
{
|
||||
if (table_join.kind() == ASTTableJoin::Kind::Inner || table_join.kind() == kind)
|
||||
{
|
||||
const auto & streams = join->getInputStreams();
|
||||
const auto & input_header = kind == ASTTableJoin::Kind::Left ? streams.front().header : streams.back().header;
|
||||
bool is_left = kind == ASTTableJoin::Kind::Left;
|
||||
const auto & input_header = is_left ? join->getInputStreams().front().header : join->getInputStreams().back().header;
|
||||
const auto & res_header = join->getOutputStream().header;
|
||||
Names allowed_keys;
|
||||
const auto & source_columns = input_header.getNames();
|
||||
@ -250,9 +250,22 @@ size_t tryPushDownFilter(QueryPlan::Node * parent_node, QueryPlan::Nodes & nodes
|
||||
|
||||
const bool can_remove_filter
|
||||
= std::find(source_columns.begin(), source_columns.end(), filter->getFilterColumnName()) == source_columns.end();
|
||||
if (auto updated_steps = tryAddNewFilterStep(parent_node, nodes, allowed_keys, can_remove_filter, kind == ASTTableJoin::Kind::Left ? 0 : 1))
|
||||
return updated_steps;
|
||||
size_t updated_steps = tryAddNewFilterStep(parent_node, nodes, allowed_keys, can_remove_filter, is_left ? 0 : 1);
|
||||
if (updated_steps > 0)
|
||||
{
|
||||
LOG_DEBUG(&Poco::Logger::get("tryPushDownFilter"), "Pushed down filter to {} side of join", kind);
|
||||
}
|
||||
return updated_steps;
|
||||
};
|
||||
|
||||
if (size_t updated_steps = join_push_down(ASTTableJoin::Kind::Left))
|
||||
return updated_steps;
|
||||
|
||||
/// For full sorting merge join we push down both to the left and right tables, because left and right streams are not independent.
|
||||
if (join->allowPushDownToRight())
|
||||
{
|
||||
if (size_t updated_steps = join_push_down(ASTTableJoin::Kind::Right))
|
||||
return updated_steps;
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user