From 4172057a4ece474fd4a6f10f18592983e2a8a989 Mon Sep 17 00:00:00 2001
From: Alexey Milovidov <milovidov@clickhouse.com>
Date: Mon, 1 Jan 2024 18:46:38 +0100
Subject: [PATCH] Fix a comment; remove unused method; stop using pointers

---
 src/Columns/ColumnFunction.h              | 5 ++---
 src/Functions/array/FunctionArrayMapped.h | 8 +++++---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/Columns/ColumnFunction.h b/src/Columns/ColumnFunction.h
index c21e88744e0..efcdc4e4419 100644
--- a/src/Columns/ColumnFunction.h
+++ b/src/Columns/ColumnFunction.h
@@ -5,6 +5,7 @@
 #include <Core/ColumnsWithTypeAndName.h>
 #include <Columns/IColumn.h>
 
+
 namespace DB
 {
 namespace ErrorCodes
@@ -16,7 +17,7 @@ class IFunctionBase;
 using FunctionBasePtr = std::shared_ptr<const IFunctionBase>;
 
 /** A column containing a lambda expression.
-  * Behaves like a constant-column. Contains an expression, but not input or output data.
+  * Contains an expression and captured columns, but not input arguments.
   */
 class ColumnFunction final : public COWHelper<IColumn, ColumnFunction>
 {
@@ -207,8 +208,6 @@ private:
     bool is_function_compiled;
 
     void appendArgument(const ColumnWithTypeAndName & column);
-
-    void addOffsetsForReplication(const IColumn::Offsets & offsets);
 };
 
 const ColumnFunction * checkAndGetShortCircuitArgument(const ColumnPtr & column);
diff --git a/src/Functions/array/FunctionArrayMapped.h b/src/Functions/array/FunctionArrayMapped.h
index a7ab80f697a..9773673c63c 100644
--- a/src/Functions/array/FunctionArrayMapped.h
+++ b/src/Functions/array/FunctionArrayMapped.h
@@ -74,6 +74,8 @@ public:
     size_t getNumberOfArguments() const override { return 0; }
     bool isSuitableForShortCircuitArgumentsExecution(const DataTypesWithConstInfo & /*arguments*/) const override { return true; }
 
+    bool useDefaultImplementationForConstants() const override { return true; }
+
     /// Called if at least one function argument is a lambda expression.
     /// For argument-lambda expressions, it defines the types of arguments of these expressions.
     void getLambdaArgumentTypes(DataTypes & arguments) const override
@@ -370,10 +372,10 @@ public:
 
             /// Put all the necessary columns multiplied by the sizes of arrays into the columns.
             auto replicated_column_function_ptr = IColumn::mutate(column_function->replicate(column_first_array->getOffsets()));
-            auto * replicated_column_function = typeid_cast<ColumnFunction *>(replicated_column_function_ptr.get());
-            replicated_column_function->appendArguments(arrays);
+            auto & replicated_column_function = typeid_cast<ColumnFunction &>(*replicated_column_function_ptr);
+            replicated_column_function.appendArguments(arrays);
 
-            auto lambda_result = replicated_column_function->reduce();
+            auto lambda_result = replicated_column_function.reduce();
 
             /// Convert LowCardinality(T) -> T and Const(LowCardinality(T)) -> Const(T),
             /// because we removed LowCardinality from return type of lambda expression.