From 41e8345169616ea052e09dcd5f54aea8c5253c62 Mon Sep 17 00:00:00 2001
From: chen768959 <934103231@qq.com>
Date: Sat, 5 Aug 2023 17:35:25 +0800
Subject: [PATCH] Add the optimize_type_ids parameter to control whether
 optimization is enabled.

---
 src/DataTypes/FieldToDataType.cpp   | 2 +-
 src/DataTypes/getLeastSupertype.cpp | 7 ++++---
 src/DataTypes/getLeastSupertype.h   | 2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/DataTypes/FieldToDataType.cpp b/src/DataTypes/FieldToDataType.cpp
index 0a48c43ceb2..9b8e476067e 100644
--- a/src/DataTypes/FieldToDataType.cpp
+++ b/src/DataTypes/FieldToDataType.cpp
@@ -155,7 +155,7 @@ DataTypePtr FieldToDataType<on_error>::operator() (const Array & x) const
     for (const Field & elem : x)
         element_types.emplace_back(applyVisitor(*this, elem));
 
-    return std::make_shared<DataTypeArray>(getLeastSupertype<on_error>(element_types));
+    return std::make_shared<DataTypeArray>(getLeastSupertype<on_error>(element_types, true));
 }
 
 template <LeastSupertypeOnError on_error>
diff --git a/src/DataTypes/getLeastSupertype.cpp b/src/DataTypes/getLeastSupertype.cpp
index 5a24a59a60e..f3b396ba895 100644
--- a/src/DataTypes/getLeastSupertype.cpp
+++ b/src/DataTypes/getLeastSupertype.cpp
@@ -201,7 +201,7 @@ DataTypePtr getNumericType(const TypeIndexSet & types)
 }
 
 template <LeastSupertypeOnError on_error>
-DataTypePtr getLeastSupertype(const DataTypes & types)
+DataTypePtr getLeastSupertype(const DataTypes & types, bool optimize_type_ids)
 {
     /// Trivial cases
 
@@ -592,7 +592,8 @@ DataTypePtr getLeastSupertype(const DataTypes & types)
 
     /// For numeric types, the most complicated part.
     {
-        optimizeTypeIds(types, type_ids);
+        if (optimize_type_ids)
+            optimizeTypeIds(types, type_ids);
         auto numeric_type = getNumericType<on_error>(type_ids);
         if (numeric_type)
             return numeric_type;
@@ -798,7 +799,7 @@ DataTypePtr tryGetLeastSupertype(const TypeIndexSet & types)
     return getLeastSupertype<LeastSupertypeOnError::Null>(types);
 }
 
-template DataTypePtr getLeastSupertype<LeastSupertypeOnError::Throw>(const DataTypes & types);
+template DataTypePtr getLeastSupertype<LeastSupertypeOnError::Throw>(const DataTypes & types, bool optimize_type_ids);
 template DataTypePtr getLeastSupertype<LeastSupertypeOnError::Throw>(const TypeIndexSet & types);
 
 }
diff --git a/src/DataTypes/getLeastSupertype.h b/src/DataTypes/getLeastSupertype.h
index 0a3fa3c2536..ba43b3966f9 100644
--- a/src/DataTypes/getLeastSupertype.h
+++ b/src/DataTypes/getLeastSupertype.h
@@ -18,7 +18,7 @@ enum class LeastSupertypeOnError
   * Examples: there is no least common supertype for Array(UInt8), Int8.
   */
 template <LeastSupertypeOnError on_error = LeastSupertypeOnError::Throw>
-DataTypePtr getLeastSupertype(const DataTypes & types);
+DataTypePtr getLeastSupertype(const DataTypes & types, bool optimize_type_ids = false);
 
 /// Same as above but return String type instead of throwing exception.
 /// All types can be casted to String, because they can be serialized to String.