thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-09 17:14:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

[rev 2] Fix review notes

Browse Source
This commit is contained in:
Aleksei Filatov 2023-01-19 18:48:09 +03:00
parent afada0ecb3
commit 42549e89f2
6 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

0
tests/integration/test_dictionaries_with_bad_structure/__init__.py → tests/integration/test_dictionaries_with_invalid_structure/__init__.py
View File

0
tests/integration/test_dictionaries_with_bad_structure/configs/config.xml → tests/integration/test_dictionaries_with_invalid_structure/configs/config.xml
View File

4
tests/integration/test_dictionaries_with_bad_structure/configs/dictionaries/invalid_dict.xml → tests/integration/test_dictionaries_with_invalid_structure/configs/dictionaries/invalid_dict.xml
View File

@ -25,8 +25,8 @@
</id>
<attribute>
<name>bad_attr</name>
<type>bad_type</type>
<name>invalid_attr</name>
<type>invalid_type</type>
<null_value></null_value>
<hierarchical>false</hierarchical>
<injective>false</injective>

0
tests/integration/test_dictionaries_with_bad_structure/configs/dictionaries/valid_dict.xml → tests/integration/test_dictionaries_with_invalid_structure/configs/dictionaries/valid_dict.xml
View File

0
tests/integration/test_dictionaries_with_bad_structure/configs/users.xml → tests/integration/test_dictionaries_with_invalid_structure/configs/users.xml
View File

14
tests/integration/test_dictionaries_with_bad_structure/test.py → tests/integration/test_dictionaries_with_invalid_structure/test.py
View File

@ -12,7 +12,7 @@ cluster = ClickHouseCluster(__file__)
instance = cluster.add_instance("instance", dictionaries=DICTIONARY_FILES)
VALID_DICT_NAME = "valid_dict"
BAD_DICT_NAME = "invalid_dict"
INVALID_DICT_NAME = "invalid_dict"
UNKNOWN_DATA_TYPE_EXCEPTION_STR = "DB::Exception: Unknown data type"
@ -25,12 +25,12 @@ def started_cluster():
cluster.shutdown()
def test_select_from_system_dictionaries_with_bad_dictionary(started_cluster):
def test_select_from_system_dictionaries_with_invalid_dictionary(started_cluster):
query = instance.query
assert query("SELECT name FROM system.dictionaries;").splitlines() == [
VALID_DICT_NAME,
BAD_DICT_NAME,
INVALID_DICT_NAME,
]
assert (
@ -43,14 +43,16 @@ def test_select_from_system_dictionaries_with_bad_dictionary(started_cluster):
assert (
UNKNOWN_DATA_TYPE_EXCEPTION_STR
in query(
f"select last_exception from system.dictionaries WHERE name='{BAD_DICT_NAME}';"
f"select last_exception from system.dictionaries WHERE name='{INVALID_DICT_NAME}';"
).strip()
)
def test_dictGet_func_for_bad_dictionary(started_cluster):
def test_dictGet_func_for_invalid_dictionary(started_cluster):
query = instance.query
with pytest.raises(QueryRuntimeException) as exc:
query(f"SELECT dictGetString('{BAD_DICT_NAME}', 'bad_attr', toInt64(1));")
query(
f"SELECT dictGetString('{INVALID_DICT_NAME}', 'invalid_attr', toInt64(1));"
)
assert UNKNOWN_DATA_TYPE_EXCEPTION_STR in str(exc.value)