thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 00:30:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix check table in case when there exist sparse columns

Browse Source
This commit is contained in:
Anton Popov 2022-03-14 15:17:43 +00:00
parent ed3d71d83f
commit 428bbd6377
3 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Storages/MergeTree/checkDataPart.cpp
View File

@ -98,7 +98,8 @@ IMergeTreeDataPart::Checksums checkDataPart(
};
};
SerializationInfoByName serialization_infos(columns_txt, {});
auto ratio_of_defaults = data_part->storage.getSettings()->ratio_of_defaults_for_sparse_serialization;
SerializationInfoByName serialization_infos(columns_txt, SerializationInfo::Settings{ratio_of_defaults, false});
auto serialization_path = path + IMergeTreeDataPart::SERIALIZATION_FILE_NAME;
if (disk->exists(serialization_path))

4
tests/queries/0_stateless/02235_check_table_sparse_serialization.reference Normal file
View File

@ -0,0 +1,4 @@
all_1_1_0 a Default
all_2_2_0 a Sparse
all_1_1_0 1
all_2_2_0 1

18
tests/queries/0_stateless/02235_check_table_sparse_serialization.sql Normal file
View File

@ -0,0 +1,18 @@
DROP TABLE IF EXISTS t_sparse_02235;
CREATE TABLE t_sparse_02235 (a UInt8) ENGINE = MergeTree ORDER BY tuple()
SETTINGS ratio_of_defaults_for_sparse_serialization = 0.9;
SYSTEM STOP MERGES t_sparse_02235;
INSERT INTO t_sparse_02235 SELECT 1 FROM numbers(1000);
INSERT INTO t_sparse_02235 SELECT 0 FROM numbers(1000);
SELECT name, column, serialization_kind FROM system.parts_columns
WHERE database = currentDatabase() AND table = 't_sparse_02235'
ORDER BY name, column;
SET check_query_single_value_result = 0;
CHECK TABLE t_sparse_02235;
DROP TABLE t_sparse_02235;