Fix clang-tidy

This commit is contained in:
Alexey Milovidov 2021-05-24 06:00:57 +03:00
parent 6f70feed2f
commit 4290b48a61
8 changed files with 14 additions and 10 deletions

View File

@ -14,7 +14,7 @@ namespace DB
class CompressionCodecDelta : public ICompressionCodec
{
public:
CompressionCodecDelta(UInt8 delta_bytes_size_);
explicit CompressionCodecDelta(UInt8 delta_bytes_size_);
uint8_t getMethodByte() const override;

View File

@ -20,7 +20,7 @@ class CompressionCodecDensity : public ICompressionCodec
public:
static constexpr auto DENSITY_DEFAULT_ALGO = DENSITY_ALGORITHM_CHAMELEON; // by default aim on speed
CompressionCodecDensity(DENSITY_ALGORITHM algo_);
explicit CompressionCodecDensity(DENSITY_ALGORITHM algo_);
uint8_t getMethodByte() const override;

View File

@ -19,6 +19,11 @@
namespace DB
{
/** NOTE DoubleDelta is surprisingly bad name. The only excuse is that it comes from an academic paper.
* Most people will think that "double delta" is just applying delta transform twice.
* But in fact it is something more than applying delta transform twice.
*/
/** DoubleDelta column codec implementation.
*
* Based on Gorilla paper: http://www.vldb.org/pvldb/vol8/p1816-teller.pdf, which was extended
@ -108,7 +113,7 @@ namespace DB
class CompressionCodecDoubleDelta : public ICompressionCodec
{
public:
CompressionCodecDoubleDelta(UInt8 data_bytes_size_);
explicit CompressionCodecDoubleDelta(UInt8 data_bytes_size_);
uint8_t getMethodByte() const override;

View File

@ -104,7 +104,7 @@ namespace DB
class CompressionCodecGorilla : public ICompressionCodec
{
public:
CompressionCodecGorilla(UInt8 data_bytes_size_);
explicit CompressionCodecGorilla(UInt8 data_bytes_size_);
uint8_t getMethodByte() const override;

View File

@ -22,7 +22,7 @@ namespace DB
class CompressionCodecLZ4 : public ICompressionCodec
{
public:
CompressionCodecLZ4();
explicit CompressionCodecLZ4();
uint8_t getMethodByte() const override;
@ -49,7 +49,7 @@ private:
class CompressionCodecLZ4HC : public CompressionCodecLZ4
{
public:
CompressionCodecLZ4HC(int level_);
explicit CompressionCodecLZ4HC(int level_);
protected:
UInt32 doCompressData(const char * source, UInt32 source_size, char * dest) const override;

View File

@ -20,7 +20,7 @@ namespace DB
class CompressionCodecLZSSE : public ICompressionCodec
{
public:
CompressionCodecLZSSE(UInt32 type_, UInt32 level_);
explicit CompressionCodecLZSSE(UInt32 type_, UInt32 level_);
uint8_t getMethodByte() const override;
UInt32 getMaxCompressedDataSize(UInt32 uncompressed_size) const override;

View File

@ -19,7 +19,7 @@ class CompressionCodecLizard : public ICompressionCodec
public:
static constexpr auto LIZARD_DEFAULT_LEVEL = 1;
CompressionCodecLizard(int level_);
explicit CompressionCodecLizard(int level_);
uint8_t getMethodByte() const override;

View File

@ -20,8 +20,7 @@ public:
static constexpr auto ZSTD_DEFAULT_LEVEL = 1;
static constexpr auto ZSTD_DEFAULT_LOG_WINDOW = 24;
CompressionCodecZSTD(int level_);
explicit CompressionCodecZSTD(int level_);
CompressionCodecZSTD(int level_, int window_log);
uint8_t getMethodByte() const override;