Fixing some warnings

base/base/ReplxxLineReader.cpp

@@ -378,4 +378,4 @@ void ReplxxLineReader::enableBracketedPaste()
 {
     bracketed_paste_enabled = true;
     rx.enable_bracketed_paste();
-};
+}

programs/static-files-disk-uploader/static-files-disk-uploader.cpp

@@ -71,7 +71,7 @@ void processFile(const fs::path & file_path, const fs::path & dst_path, bool tes
         dst_buf->next();
         dst_buf->finalize();
     }
-};
+}
 
 
 void processTableFiles(const fs::path & data_path, fs::path dst_path, bool test_mode, bool link)

src/AggregateFunctions/AggregateFunctionMannWhitney.h

@@ -245,4 +245,4 @@ public:
 
 };
 
-};
+}

src/AggregateFunctions/AggregateFunctionMeanZTest.h

@@ -136,4 +136,4 @@ public:
     }
 };
 
-};
+}

src/AggregateFunctions/AggregateFunctionRankCorrelation.h

@@ -102,4 +102,4 @@ public:
 
 };
 
-};
+}

src/AggregateFunctions/AggregateFunctionTTest.h

@@ -234,4 +234,4 @@ public:
     }
 };
 
-};
+}

src/Common/Config/AbstractConfigurationComparison.cpp

@@ -18,7 +18,7 @@ namespace
             result += '.';
         result += subkey;
         return result;
-    };
+    }
 }
 
 

src/Common/Config/configReadClient.cpp

@@ -14,7 +14,7 @@ bool safeFsExists(const String & path)
 {
     std::error_code ec;
     return fs::exists(path, ec);
-};
+}
 
 bool configReadClient(Poco::Util::LayeredConfiguration & config, const std::string & home_path)
 {

src/Common/Exception.h

@@ -48,8 +48,8 @@ public:
 
     Exception * clone() const override { return new Exception(*this); }
     void rethrow() const override { throw *this; }
-    const char * name() const throw() override { return "DB::Exception"; }
-    const char * what() const throw() override { return message().data(); }
+    const char * name() const noexcept override { return "DB::Exception"; }
+    const char * what() const noexcept override { return message().data(); }
 
     /// Add something to the existing message.
     template <typename... Args>
@@ -77,7 +77,7 @@ private:
 #endif
     bool remote = false;
 
-    const char * className() const throw() override { return "DB::Exception"; }
+    const char * className() const noexcept override { return "DB::Exception"; }
 };
 
 
@@ -102,8 +102,8 @@ private:
     int saved_errno;
     std::optional<std::string> path;
 
-    const char * name() const throw() override { return "DB::ErrnoException"; }
-    const char * className() const throw() override { return "DB::ErrnoException"; }
+    const char * name() const noexcept override { return "DB::ErrnoException"; }
+    const char * className() const noexcept override { return "DB::ErrnoException"; }
 };
 
 
@@ -143,8 +143,8 @@ private:
     String file_name;
     mutable std::string formatted_message;
 
-    const char * name() const throw() override { return "DB::ParsingException"; }
-    const char * className() const throw() override { return "DB::ParsingException"; }
+    const char * name() const noexcept override { return "DB::ParsingException"; }
+    const char * className() const noexcept override { return "DB::ParsingException"; }
 };
 
 

src/Common/NetException.h

@@ -22,8 +22,8 @@ public:
     void rethrow() const override { throw *this; }
 
 private:
-    const char * name() const throw() override { return "DB::NetException"; }
-    const char * className() const throw() override { return "DB::NetException"; }
+    const char * name() const noexcept override { return "DB::NetException"; }
+    const char * className() const noexcept override { return "DB::NetException"; }
 };
 
 }

src/Common/SensitiveDataMasker.h

@@ -69,4 +69,4 @@ public:
     size_t rulesCount() const;
 };
 
-};
+}

src/Common/ZooKeeper/IKeeper.h

@@ -401,8 +401,8 @@ public:
     Exception(const Error code_, const std::string & path); /// NOLINT
     Exception(const Exception & exc);
 
-    const char * name() const throw() override { return "Coordination::Exception"; }
-    const char * className() const throw() override { return "Coordination::Exception"; }
+    const char * name() const noexcept override { return "Coordination::Exception"; }
+    const char * className() const noexcept override { return "Coordination::Exception"; }
     Exception * clone() const override { return new Exception(*this); }
 
     const Error code;

src/Core/Block.cpp

@@ -35,7 +35,7 @@ static ReturnType onError(const std::string & message [[maybe_unused]], int code
         throw Exception(message, code);
     else
         return false;
-};
+}
 
 
 template <typename ReturnType>

src/Daemon/BaseDaemon.cpp

@@ -451,7 +451,7 @@ static std::string createDirectory(const std::string & file)
         return "";
     fs::create_directories(path);
     return path;
-};
+}
 
 
 static bool tryCreateDirectories(Poco::Logger * logger, const std::string & path)
@@ -794,7 +794,7 @@ static void addSignalHandler(const std::vector<int> & signals, signal_function h
 
     if (out_handled_signals)
         std::copy(signals.begin(), signals.end(), std::back_inserter(*out_handled_signals));
-};
+}
 
 
 static void blockSignals(const std::vector<int> & signals)
@@ -816,7 +816,7 @@ static void blockSignals(const std::vector<int> & signals)
 
     if (pthread_sigmask(SIG_BLOCK, &sig_set, nullptr))
         throw Poco::Exception("Cannot block signal.");
-};
+}
 
 
 void BaseDaemon::initializeTerminationAndSignalProcessing()

src/Daemon/SentryWriter.h

@@ -24,4 +24,4 @@ namespace SentryWriter
         int sig,
         const std::string & error_message,
         const StackTrace & stack_trace);
-};
+}

src/Dictionaries/DictionaryStructure.h

@@ -89,7 +89,7 @@ constexpr void callOnDictionaryAttributeType(AttributeUnderlyingType type, F &&
         if (type == other)
             func(DictionaryAttributeType<other>{});
     });
-};
+}
 
 struct DictionarySpecialAttribute final
 {

src/Functions/addSubSeconds.cpp

@@ -9,19 +9,19 @@ using FunctionAddNanoseconds = FunctionDateOrDateTimeAddInterval<AddNanosecondsI
 void registerFunctionAddNanoseconds(FunctionFactory & factory)
 {
     factory.registerFunction<FunctionAddNanoseconds>();
-};
+}
 
 using FunctionAddMicroseconds = FunctionDateOrDateTimeAddInterval<AddMicrosecondsImpl>;
 void registerFunctionAddMicroseconds(FunctionFactory & factory)
 {
     factory.registerFunction<FunctionAddMicroseconds>();
-};
+}
 
 using FunctionAddMilliseconds = FunctionDateOrDateTimeAddInterval<AddMillisecondsImpl>;
 void registerFunctionAddMilliseconds(FunctionFactory & factory)
 {
     factory.registerFunction<FunctionAddMilliseconds>();
-};
+}
 
 }
 

src/Interpreters/Context.cpp

@@ -1378,7 +1378,7 @@ void Context::killCurrentQuery()
     {
         process_list_elem->cancelQuery(true);
     }
-};
+}
 
 String Context::getDefaultFormat() const
 {

src/Interpreters/FilesystemCacheLog.cpp

@@ -75,4 +75,4 @@ void FilesystemCacheLogElement::appendToBlock(MutableColumns & columns) const
     columns[i++]->insert(read_buffer_id);
 }
 
-};
+}

src/Interpreters/FilesystemCacheLog.h

@@ -58,4 +58,4 @@ class FilesystemCacheLog : public SystemLog<FilesystemCacheLogElement>
     using SystemLog<FilesystemCacheLogElement>::SystemLog;
 };
 
-};
+}

src/Interpreters/HashJoin.cpp

@@ -1176,7 +1176,7 @@ void addFoundRowAll(
             ++current_offset;
         }
     }
-};
+}
 
 template <bool add_missing, bool need_offset>
 void addNotFoundRow(AddedColumns & added [[maybe_unused]], IColumn::Offset & current_offset [[maybe_unused]])

src/Interpreters/InterpreterInsertQuery.cpp

@@ -203,7 +203,7 @@ static bool isTrivialSelect(const ASTPtr & select)
     }
     /// This query is ASTSelectWithUnionQuery subquery
     return false;
-};
+}
 
 Chain InterpreterInsertQuery::buildChain(
     const StoragePtr & table,

src/Interpreters/UserDefinedExecutableFunction.cpp

@@ -21,4 +21,4 @@ UserDefinedExecutableFunction::UserDefinedExecutableFunction(
 {
 }
 
-};
+}

src/Interpreters/ZooKeeperLog.cpp

@@ -209,4 +209,4 @@ void ZooKeeperLogElement::appendToBlock(MutableColumns & columns) const
     columns[i++]->insert(children_array);
 }
 
-};
+}

src/Loggers/Loggers.cpp

@@ -32,7 +32,7 @@ static std::string createDirectory(const std::string & file)
         return "";
     fs::create_directories(path);
     return path;
-};
+}
 
 #ifdef WITH_TEXT_LOG
 void Loggers::setTextLog(std::shared_ptr<DB::TextLog> log, int max_priority)

src/Storages/MergeTree/MergeTreeIndexMinMax.cpp

@@ -196,7 +196,7 @@ MergeTreeIndexConditionPtr MergeTreeIndexMinMax::createIndexCondition(
     const SelectQueryInfo & query, ContextPtr context) const
 {
     return std::make_shared<MergeTreeIndexConditionMinMax>(index, query, context);
-};
+}
 
 bool MergeTreeIndexMinMax::mayBenefitFromIndexForIn(const ASTPtr & node) const
 {

src/Storages/MergeTree/RPNBuilder.h

@@ -120,4 +120,4 @@ private:
 };
 
 
-};
+}

src/Storages/StorageExecutable.cpp

@@ -234,5 +234,5 @@ void registerStorageExecutable(StorageFactory & factory)
     }, storage_features);
 }
 
-};
+}