From 51edcf232cf2962d51d57f808ab6cea42e28327d Mon Sep 17 00:00:00 2001
From: Nikolay Degterinsky <evillique@gmail.com>
Date: Wed, 8 Mar 2023 00:52:58 +0000
Subject: [PATCH] Add support for big int types to runningDifference() function

---
 src/Functions/runningDifference.h             | 10 +++++++-
 .../queries/0_stateless/00534_filimonov.data  |  8 +++++++
 .../00653_running_difference.reference        | 24 +++++++++++++++++++
 .../0_stateless/00653_running_difference.sql  |  8 +++++++
 4 files changed, 49 insertions(+), 1 deletion(-)

diff --git a/src/Functions/runningDifference.h b/src/Functions/runningDifference.h
index 154370d4cd9..f1ec4f9e523 100644
--- a/src/Functions/runningDifference.h
+++ b/src/Functions/runningDifference.h
@@ -70,7 +70,7 @@ private:
 
             if (!has_prev_value)
             {
-                dst[i] = is_first_line_zero ? 0 : src[i];
+                dst[i] = is_first_line_zero ? static_cast<Dst>(0) : static_cast<Dst>(src[i]);
                 prev = src[i];
                 has_prev_value = true;
             }
@@ -102,6 +102,10 @@ private:
             f(UInt32());
         else if (which.isUInt64())
             f(UInt64());
+        else if (which.isUInt128())
+            f(UInt128());
+        else if (which.isUInt256())
+            f(UInt256());
         else if (which.isInt8())
             f(Int8());
         else if (which.isInt16())
@@ -110,6 +114,10 @@ private:
             f(Int32());
         else if (which.isInt64())
             f(Int64());
+        else if (which.isInt128())
+            f(Int128());
+        else if (which.isInt256())
+            f(Int256());
         else if (which.isFloat32())
             f(Float32());
         else if (which.isFloat64())
diff --git a/tests/queries/0_stateless/00534_filimonov.data b/tests/queries/0_stateless/00534_filimonov.data
index 911a8e4d1f3..eb4500877e5 100644
--- a/tests/queries/0_stateless/00534_filimonov.data
+++ b/tests/queries/0_stateless/00534_filimonov.data
@@ -276,10 +276,14 @@ SELECT runningDifference(CAST( 0  AS Nullable(Int8)));
 SELECT runningDifference(CAST( 0  AS Nullable(Int16)));
 SELECT runningDifference(CAST( 0  AS Nullable(Int32)));
 SELECT runningDifference(CAST( 0  AS Nullable(Int64)));
+SELECT runningDifference(CAST( 0  AS Nullable(Int128)));
+SELECT runningDifference(CAST( 0  AS Nullable(Int256)));
 SELECT runningDifference(CAST( 0  AS Nullable(UInt8)));
 SELECT runningDifference(CAST( 0  AS Nullable(UInt16)));
 SELECT runningDifference(CAST( 0  AS Nullable(UInt32)));
 SELECT runningDifference(CAST( 0  AS Nullable(UInt64)));
+SELECT runningDifference(CAST( 0  AS Nullable(UInt128)));
+SELECT runningDifference(CAST( 0  AS Nullable(UInt256)));
 SELECT runningDifference(CAST( 0  AS Nullable(Float32)));
 SELECT runningDifference(CAST( 0  AS Nullable(Float64)));
 SELECT runningDifference(CAST( 0  AS Nullable(Date)));
@@ -288,10 +292,14 @@ SELECT runningDifference(CAST(NULL AS Nullable(Int8)));
 SELECT runningDifference(CAST(NULL AS Nullable(Int16)));
 SELECT runningDifference(CAST(NULL AS Nullable(Int32)));
 SELECT runningDifference(CAST(NULL AS Nullable(Int64)));
+SELECT runningDifference(CAST(NULL AS Nullable(Int128)));
+SELECT runningDifference(CAST(NULL AS Nullable(Int256)));
 SELECT runningDifference(CAST(NULL AS Nullable(UInt8)));
 SELECT runningDifference(CAST(NULL AS Nullable(UInt16)));
 SELECT runningDifference(CAST(NULL AS Nullable(UInt32)));
 SELECT runningDifference(CAST(NULL AS Nullable(UInt64)));
+SELECT runningDifference(CAST(NULL AS Nullable(UInt128)));
+SELECT runningDifference(CAST(NULL AS Nullable(UInt256));
 SELECT runningDifference(CAST(NULL AS Nullable(Float32)));
 SELECT runningDifference(CAST(NULL AS Nullable(Float64)));
 SELECT runningDifference(CAST(NULL AS Nullable(Date)));
diff --git a/tests/queries/0_stateless/00653_running_difference.reference b/tests/queries/0_stateless/00653_running_difference.reference
index e2833e0bb3e..624ce92ce0f 100644
--- a/tests/queries/0_stateless/00653_running_difference.reference
+++ b/tests/queries/0_stateless/00653_running_difference.reference
@@ -19,6 +19,30 @@
 \N
 \N
 2
+-
+0
+1
+4
+5
+170141183460469231731687303715884105717
+-
+0
+1
+4
+5
+170141183460469231731687303715884105718
+-
+0
+1
+4
+5
+170141183460469231731687303715884105717
+-
+0
+1
+4
+5
+170141183460469231731687303715884105718
 --Date Difference--
 \N
 \N
diff --git a/tests/queries/0_stateless/00653_running_difference.sql b/tests/queries/0_stateless/00653_running_difference.sql
index f2b4a7300b2..1f18cfc42a7 100644
--- a/tests/queries/0_stateless/00653_running_difference.sql
+++ b/tests/queries/0_stateless/00653_running_difference.sql
@@ -5,6 +5,14 @@ select '-';
 select runningDifference(x) from (select arrayJoin([Null, 1]) as x);
 select '-';
 select runningDifference(x) from (select arrayJoin([Null, Null, 1, 3, Null, Null, 5]) as x);
+select '-';
+select runningDifference(x) from (select arrayJoin([0, 1, 5, 10, 170141183460469231731687303715884105727]::Array(UInt128)) as x);
+select '-';
+select runningDifference(x) from (select arrayJoin([0, 1, 5, 10, 170141183460469231731687303715884105728]::Array(UInt256)) as x);
+select '-';
+select runningDifference(x) from (select arrayJoin([0, 1, 5, 10, 170141183460469231731687303715884105727]::Array(Int128)) as x);
+select '-';
+select runningDifference(x) from (select arrayJoin([0, 1, 5, 10, 170141183460469231731687303715884105728]::Array(Int256)) as x);
 select '--Date Difference--';
 select runningDifference(x) from (select arrayJoin([Null, Null, toDate('1970-1-1'), toDate('1970-12-31'), Null, Null,  toDate('2010-8-9')]) as x);
 select '-';