thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-19 16:20:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better logging for announcement

Browse Source
This commit is contained in:
Igor Nikonov 2024-07-22 16:39:07 +00:00
parent 9900abade6
commit 4483f4b389
2 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Storages/MergeTree/ParallelReplicasReadingCoordinator.cpp
View File

@ -433,12 +433,11 @@ void DefaultCoordinator::setProgressCallback()
void DefaultCoordinator::doHandleInitialAllRangesAnnouncement(InitialAllRangesAnnouncement announcement) void DefaultCoordinator::doHandleInitialAllRangesAnnouncement(InitialAllRangesAnnouncement announcement)
{ {
const auto replica_num = announcement.replica_num; LOG_DEBUG(log, "Initial request: {}", announcement.describe());
LOG_DEBUG(log, "Initial request from replica {}: {}", announcement.replica_num, announcement.describe());
initializeReadingState(std::move(announcement)); initializeReadingState(std::move(announcement));
const auto replica_num = announcement.replica_num;
if (replica_num >= stats.size()) if (replica_num >= stats.size())
throw Exception( throw Exception(
ErrorCodes::LOGICAL_ERROR, "Replica number ({}) is bigger than total replicas count ({})", replica_num, stats.size()); ErrorCodes::LOGICAL_ERROR, "Replica number ({}) is bigger than total replicas count ({})", replica_num, stats.size());
@ -859,7 +858,7 @@ void InOrderCoordinator<mode>::markReplicaAsUnavailable(size_t replica_number)
template <CoordinationMode mode> template <CoordinationMode mode>
void InOrderCoordinator<mode>::doHandleInitialAllRangesAnnouncement(InitialAllRangesAnnouncement announcement) void InOrderCoordinator<mode>::doHandleInitialAllRangesAnnouncement(InitialAllRangesAnnouncement announcement)
{ {
LOG_TRACE(log, "Received an announcement {}", announcement.describe()); LOG_TRACE(log, "Received an announcement : {}", announcement.describe());
++stats[announcement.replica_num].number_of_requests; ++stats[announcement.replica_num].number_of_requests;

5
src/Storages/MergeTree/RequestResponse.cpp
View File

@ -129,10 +129,7 @@ void InitialAllRangesAnnouncement::serialize(WriteBuffer & out) const
String InitialAllRangesAnnouncement::describe() String InitialAllRangesAnnouncement::describe()
{ {
String result; return fmt::format("replica {}, mode {}, {}", replica_num, mode, description.describe());
result += description.describe();
result += fmt::format("----------\nReceived from {} replica\n", replica_num);
return result;
} }
InitialAllRangesAnnouncement InitialAllRangesAnnouncement::deserialize(ReadBuffer & in) InitialAllRangesAnnouncement InitialAllRangesAnnouncement::deserialize(ReadBuffer & in)