thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-17 13:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Throw type mismatch exception from inferJoinKeyCommonType

Browse Source
This commit is contained in:
vdimir 2021-06-29 12:55:34 +03:00
parent df873866c9
commit 450e49fd28
No known key found for this signature in database
GPG Key ID: F57B3E10A21DBB31
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/Interpreters/TableJoin.cpp
View File

@ -428,19 +428,17 @@ bool TableJoin::inferJoinKeyCommonType(const LeftNamesAndTypes & left, const Rig
auto common_type = DB::getLeastSupertype({ltype->second, rtype->second}, false); auto common_type = DB::getLeastSupertype({ltype->second, rtype->second}, false);
if (common_type == nullptr || isNothing(common_type)) if (common_type == nullptr || isNothing(common_type))
{ {
LOG_DEBUG(&Poco::Logger::get("TableJoin"), throw DB::Exception(ErrorCodes::TYPE_MISMATCH,
"Can't infer supertype for joined columns: {}: {} at left, {}: {} at right.", "Can't infer supertype for joined columns: {}: {} at left, {}: {} at right.",
key_names_left[i], ltype->second->getName(), key_names_left[i], ltype->second->getName(),
key_names_right[i], rtype->second->getName()); key_names_right[i], rtype->second->getName());
continue;
} }
if (!allow_right && !common_type->equals(*rtype->second)) if (!allow_right && !common_type->equals(*rtype->second))
{ {
LOG_DEBUG(&Poco::Logger::get("TableJoin"), throw DB::Exception(ErrorCodes::TYPE_MISMATCH,
"Can't change type for right table: {}: {} -> {}.", "Can't change type for right table: {}: {} -> {}.",
key_names_right[i], rtype->second->getName(), common_type->getName()); key_names_right[i], rtype->second->getName(), common_type->getName());
continue;
} }
left_type_map[key_names_left[i]] = right_type_map[key_names_right[i]] = common_type; left_type_map[key_names_left[i]] = right_type_map[key_names_right[i]] = common_type;
} }