From 451a8308c3f84005a2c3dc79ee72ae374bfea56a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mi=D1=81hael=20Stetsyuk?= <59827607+mstetsyuk@users.noreply.github.com> Date: Thu, 19 Sep 2024 13:56:41 +0100 Subject: [PATCH] Update src/Interpreters/convertFieldToType.cpp Co-authored-by: Kruglov Pavel <48961922+Avogar@users.noreply.github.com> --- src/Interpreters/convertFieldToType.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Interpreters/convertFieldToType.cpp b/src/Interpreters/convertFieldToType.cpp index 66ba44ee411..b831f6fad02 100644 --- a/src/Interpreters/convertFieldToType.cpp +++ b/src/Interpreters/convertFieldToType.cpp @@ -574,6 +574,7 @@ Field convertFieldToTypeImpl(const Field & src, const IDataType & type, const ID Field tryConvertFieldToType(const Field & from_value, const IDataType & to_type, const IDataType * from_type_hint, const FormatSettings & format_settings) { + /// TODO: implement proper tryConvertFieldToType without try/catch by adding template flag to convertFieldToTypeImpl to not throw an exception. try { return convertFieldToType(from_value, to_type, from_type_hint, format_settings);