Merging function 'repeat'

This commit is contained in:
Alexey Milovidov 2019-09-23 02:30:13 +03:00
parent 52272eeea9
commit 454b83fcd3
2 changed files with 59 additions and 76 deletions

View File

@ -1,4 +1,3 @@
#include <Columns/ColumnFixedString.h>
#include <Columns/ColumnString.h> #include <Columns/ColumnString.h>
#include <Columns/ColumnVector.h> #include <Columns/ColumnVector.h>
#include <DataTypes/DataTypeString.h> #include <DataTypes/DataTypeString.h>
@ -18,38 +17,29 @@ namespace ErrorCodes
struct RepeatImpl struct RepeatImpl
{ {
static void vectorNonConstStr( static void vectorStrConstRepeat(
const ColumnString::Chars & data, const ColumnString::Chars & data,
const ColumnString::Offsets & offsets, const ColumnString::Offsets & offsets,
ColumnString::Chars & res_data, ColumnString::Chars & res_data,
ColumnString::Offsets & res_offsets, ColumnString::Offsets & res_offsets,
const UInt64 & repeat_time) UInt64 repeat_time)
{ {
UInt64 data_size = 0; UInt64 data_size = 0;
res_offsets.assign(offsets); res_offsets.assign(offsets);
for (UInt64 i = 0; i < offsets.size(); ++i) for (UInt64 i = 0; i < offsets.size(); ++i)
{ {
data_size += (offsets[i] - offsets[i - 1] - 1) * repeat_time + 1; data_size += (offsets[i] - offsets[i - 1] - 1) * repeat_time + 1; /// Note that accessing -1th element is valid for PaddedPODArray.
res_offsets[i] = data_size; res_offsets[i] = data_size;
} }
res_data.resize(data_size); res_data.resize(data_size);
for (UInt64 i = 0; i < res_offsets.size(); ++i) for (UInt64 i = 0; i < res_offsets.size(); ++i)
{ {
array(data.data() + offsets[i - 1], res_data.data() + res_offsets[i - 1], offsets[i] - offsets[i - 1], repeat_time); process(data.data() + offsets[i - 1], res_data.data() + res_offsets[i - 1], offsets[i] - offsets[i - 1], repeat_time);
} }
} }
static void
vectorConst(const String & copy_str, const UInt64 & repeat_time, ColumnString::Chars & res_data, ColumnString::Offsets & res_offsets)
{
UInt64 data_size = copy_str.size() * repeat_time + 1;
res_data.resize(data_size);
res_offsets.resize_fill(1, data_size);
array(reinterpret_cast<UInt8 *>(const_cast<char *>(copy_str.data())), res_data.data(), copy_str.size() + 1, repeat_time);
}
template <typename T> template <typename T>
static void vectorNonConst( static void vectorStrVectorRepeat(
const ColumnString::Chars & data, const ColumnString::Chars & data,
const ColumnString::Offsets & offsets, const ColumnString::Offsets & offsets,
ColumnString::Chars & res_data, ColumnString::Chars & res_data,
@ -66,17 +56,20 @@ struct RepeatImpl
res_data.resize(data_size); res_data.resize(data_size);
for (UInt64 i = 0; i < col_num.size(); ++i) for (UInt64 i = 0; i < col_num.size(); ++i)
{ {
array(data.data() + offsets[i - 1], res_data.data() + res_offsets[i - 1], offsets[i] - offsets[i - 1], col_num[i]); process(data.data() + offsets[i - 1], res_data.data() + res_offsets[i - 1], offsets[i] - offsets[i - 1], col_num[i]);
} }
} }
template <typename T> template <typename T>
static void vectorNonConstInteger( static void constStrVectorRepeat(
const String & copy_str, ColumnString::Chars & res_data, ColumnString::Offsets & res_offsets, const PaddedPODArray<T> & col_num) const StringRef & copy_str,
ColumnString::Chars & res_data,
ColumnString::Offsets & res_offsets,
const PaddedPODArray<T> & col_num)
{ {
UInt64 data_size = 0; UInt64 data_size = 0;
res_offsets.resize(col_num.size()); res_offsets.resize(col_num.size());
UInt64 str_size = copy_str.size(); UInt64 str_size = copy_str.size;
UInt64 col_size = col_num.size(); UInt64 col_size = col_num.size();
for (UInt64 i = 0; i < col_size; ++i) for (UInt64 i = 0; i < col_size; ++i)
{ {
@ -86,8 +79,8 @@ struct RepeatImpl
res_data.resize(data_size); res_data.resize(data_size);
for (UInt64 i = 0; i < col_size; ++i) for (UInt64 i = 0; i < col_size; ++i)
{ {
array( process(
reinterpret_cast<UInt8 *>(const_cast<char *>(copy_str.data())), reinterpret_cast<UInt8 *>(const_cast<char *>(copy_str.data)),
res_data.data() + res_offsets[i - 1], res_data.data() + res_offsets[i - 1],
str_size + 1, str_size + 1,
col_num[i]); col_num[i]);
@ -95,7 +88,7 @@ struct RepeatImpl
} }
private: private:
static void array(const UInt8 * src, UInt8 * dst, const UInt64 & size, const UInt64 & repeat_time) static void process(const UInt8 * src, UInt8 * dst, UInt64 size, UInt64 repeat_time)
{ {
for (UInt64 i = 0; i < repeat_time; ++i) for (UInt64 i = 0; i < repeat_time; ++i)
{ {
@ -106,8 +99,8 @@ private:
} }
}; };
template <typename Impl>
class FunctionRepeatImpl : public IFunction class FunctionRepeat : public IFunction
{ {
template <typename F> template <typename F>
static bool castType(const IDataType * type, F && f) static bool castType(const IDataType * type, F && f)
@ -117,7 +110,7 @@ class FunctionRepeatImpl : public IFunction
public: public:
static constexpr auto name = "repeat"; static constexpr auto name = "repeat";
static FunctionPtr create(const Context &) { return std::make_shared<FunctionRepeatImpl>(); } static FunctionPtr create(const Context &) { return std::make_shared<FunctionRepeat>(); }
String getName() const override { return name; } String getName() const override { return name; }
@ -138,74 +131,64 @@ public:
void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t) override void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t) override
{ {
auto & strcolumn = block.getByPosition(arguments[0]).column; const auto & strcolumn = block.getByPosition(arguments[0]).column;
auto & numcolumn = block.getByPosition(arguments[1]).column; const auto & numcolumn = block.getByPosition(arguments[1]).column;
if (const ColumnString * col = checkAndGetColumn<ColumnString>(strcolumn.get())) if (const ColumnString * col = checkAndGetColumn<ColumnString>(strcolumn.get()))
{ {
if (const ColumnConst * scale_column_num = checkAndGetColumn<ColumnConst>(numcolumn.get())) if (const ColumnConst * scale_column_num = checkAndGetColumn<ColumnConst>(numcolumn.get()))
{ {
Field scale_field_num = scale_column_num->getField(); UInt64 repeat_time = scale_column_num->getValue<UInt64>();
UInt64 repeat_time = scale_field_num.get<UInt64>();
auto col_res = ColumnString::create(); auto col_res = ColumnString::create();
Impl::vectorNonConstStr(col->getChars(), col->getOffsets(), col_res->getChars(), col_res->getOffsets(), repeat_time); RepeatImpl::vectorStrConstRepeat(col->getChars(), col->getOffsets(), col_res->getChars(), col_res->getOffsets(), repeat_time);
block.getByPosition(result).column = std::move(col_res); block.getByPosition(result).column = std::move(col_res);
return;
} }
else if (!castType(block.getByPosition(arguments[1]).type.get(), [&](const auto & type) else if (castType(block.getByPosition(arguments[1]).type.get(), [&](const auto & type)
{
using DataType = std::decay_t<decltype(type)>;
using T0 = typename DataType::FieldType;
const ColumnVector<T0> * colnum = checkAndGetColumn<ColumnVector<T0>>(numcolumn.get());
auto col_res = ColumnString::create();
Impl::vectorNonConst(col->getChars(), col->getOffsets(), col_res->getChars(), col_res->getOffsets(), colnum->getData());
block.getByPosition(result).column = std::move(col_res);
return 0;
}));
else
throw Exception(
"Illegal column " + block.getByPosition(arguments[1]).column->getName() + " of argument of function " + getName(),
ErrorCodes::ILLEGAL_COLUMN);
}
else if (const ColumnConst * scale_column_str = checkAndGetColumn<ColumnConst>(strcolumn.get()))
{
Field scale_field_str = scale_column_str->getField();
String copy_str = scale_field_str.get<String>();
if (const ColumnConst * scale_column_num = checkAndGetColumn<ColumnConst>(numcolumn.get()))
{
Field scale_field_num = scale_column_num->getField();
UInt64 repeat_time = scale_field_num.get<UInt64>();
auto col_res = ColumnString::create();
Impl::vectorConst(copy_str, repeat_time, col_res->getChars(), col_res->getOffsets());
block.getByPosition(result).column = std::move(col_res);
}
else if (!castType(block.getByPosition(arguments[1]).type.get(), [&](const auto & type)
{ {
using DataType = std::decay_t<decltype(type)>; using DataType = std::decay_t<decltype(type)>;
using T0 = typename DataType::FieldType; using T = typename DataType::FieldType;
const ColumnVector<T0> * colnum = checkAndGetColumn<ColumnVector<T0>>(numcolumn.get()); const ColumnVector<T> * colnum = checkAndGetColumn<ColumnVector<T>>(numcolumn.get());
auto col_res = ColumnString::create(); auto col_res = ColumnString::create();
Impl::vectorNonConstInteger(copy_str, col_res->getChars(), col_res->getOffsets(), colnum->getData()); RepeatImpl::vectorStrVectorRepeat(col->getChars(), col->getOffsets(), col_res->getChars(), col_res->getOffsets(), colnum->getData());
block.getByPosition(result).column = std::move(col_res); block.getByPosition(result).column = std::move(col_res);
return 0; return true;
})) }))
{ {
return;
} }
else
throw Exception(
"Illegal column " + block.getByPosition(arguments[1]).column->getName() + " of argument of function " + getName(),
ErrorCodes::ILLEGAL_COLUMN);
} }
else else if (const ColumnConst * col_const = checkAndGetColumn<ColumnConst>(strcolumn.get()))
throw Exception( {
"Illegal column " + block.getByPosition(arguments[0]).column->getName() + " of argument of function " + getName(), /// Note that const-const case is handled by useDefaultImplementationForConstants.
ErrorCodes::ILLEGAL_COLUMN);
StringRef copy_str = col_const->getDataColumn().getDataAt(0);
if (castType(block.getByPosition(arguments[1]).type.get(), [&](const auto & type)
{
using DataType = std::decay_t<decltype(type)>;
using T = typename DataType::FieldType;
const ColumnVector<T> * colnum = checkAndGetColumn<ColumnVector<T>>(numcolumn.get());
auto col_res = ColumnString::create();
RepeatImpl::constStrVectorRepeat(copy_str, col_res->getChars(), col_res->getOffsets(), colnum->getData());
block.getByPosition(result).column = std::move(col_res);
return true;
}))
{
return;
}
}
throw Exception(
"Illegal column " + block.getByPosition(arguments[0]).column->getName() + " of argument of function " + getName(),
ErrorCodes::ILLEGAL_COLUMN);
} }
}; };
using FunctionRepeat = FunctionRepeatImpl<RepeatImpl>;
void registerFunctionRepeat(FunctionFactory & factory) void registerFunctionRepeat(FunctionFactory & factory)
{ {
factory.registerFunction<FunctionRepeat>(); factory.registerFunction<FunctionRepeat>();
} }
} }

View File

@ -2,11 +2,11 @@ SELECT repeat('abc', 10);
DROP TABLE IF EXISTS defaults; DROP TABLE IF EXISTS defaults;
CREATE TABLE defaults CREATE TABLE defaults
( (
strings String, strings String,
u8 UInt8, u8 UInt8,
u16 UInt16, u16 UInt16,
u32 UInt32, u32 UInt32,
u64 UInt64 u64 UInt64
)ENGINE = Memory(); )ENGINE = Memory();
INSERT INTO defaults values ('abc', 3, 12, 4, 56) ('sdfgg', 2, 10, 21, 200) ('xywq', 1, 4, 9, 5) ('plkf', 0, 5, 7,77); INSERT INTO defaults values ('abc', 3, 12, 4, 56) ('sdfgg', 2, 10, 21, 200) ('xywq', 1, 4, 9, 5) ('plkf', 0, 5, 7,77);